Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4152428pxb; Sun, 24 Oct 2021 21:26:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxIq1BLpWyz7mP3Mq4r0J8ud7xiigbnyuHiq1M/PkJlvVtAd6t4UsfhpAyK7w01WRRG7eII X-Received: by 2002:a05:6402:2793:: with SMTP id b19mr23362161ede.80.1635136001578; Sun, 24 Oct 2021 21:26:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635136001; cv=none; d=google.com; s=arc-20160816; b=ByBD6T67TfFIoGGeqzLyBdHqyTRlmYZ80JA8fl24MwBNQz48/7o94RJ1d0551z0rUX 2wn9uzerJPDCupETQHUWyDAwV9d7j7Q60VFNO7cRn3YFiB6h+tBk700eY2JS1p15x9fy HVO01A9QWu4QgB9mVRAWKpr3Q5oYDiF2ZNg9oHS0hhaEYVc/0hd+D0P2NpYp/W5sA01b aMQlAvmUWOu+XVfjYgBGeLd7B8CD/taeL7BHcuwoVSvZlPn1I1cXgEHKOIU1y+Din2Cd hjR370Q5BsU37CsBF7iWgx3nGiBr6pAENgEK9A/hidaJR4uRxzyBwAJ2DUj34FYarQIb SKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=X0qpz8rSbBXIAoRQvyjBvV/7yL/96DPKZP2hxadUMDY=; b=mEV1aQYRXQCLCiJrb7ECrRt4VWywt6TYqncJW9XmfxJPTZQiGEaMa0lYI7G7G2Uhmz ooCJquj72rruqCIAMqT6tn5MfTNjZtC9m1vwHib+8+iJhs7g9fW/gPC6pcz/Rmuk9vPM 7q4UIovMGkUy7PlzXx1KlAYIJoOaf/jc5cNtDPMZJ3QJKOeHYydx78icofBrspc8kSjU fcnfzFt7J/yHGQLIasIOudBI0YDZXXttD7ollCWZlNtAiYC+d65SDRdTFq5wXYNtrRwW PR7ZJf231tnMv247mp5KyljYGIPm3kVsQ/dk0BHQE2p+7YvvaXau1JjFIsLXHXB70mgg K+ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lYiPFiPa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd38si16434278ejc.293.2021.10.24.21.26.17; Sun, 24 Oct 2021 21:26:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lYiPFiPa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbhJYE0c (ORCPT + 99 others); Mon, 25 Oct 2021 00:26:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:53952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229678AbhJYE02 (ORCPT ); Mon, 25 Oct 2021 00:26:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C64D060F9B; Mon, 25 Oct 2021 04:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635135846; bh=Lo4ZXU3swrI/CoQaLW+tWAClSe9XbVcmKuRTaCOG7jo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lYiPFiPaqW6yqyFtyYgoFJ2Fwja8suK/ETKV3BQFokp2TWOZ4Gy36EkQ0QrtrK/Zu gO2nIKqSZxs55niusXgG6Fd+475CcSdJSU7vXFijh7G30J/lo8Ttu+yD7c2FSCf9xV dWOLX2Qkvs1RfgI3uzlICyURMniOVTR3kTBQnxYphNKvB0Igyn6D2YVgVrpnO67UU5 vUUiM+72tTAJZwUYzjth7WwS0GZKAAkjfW2ElVGkOoM1+7BXrWObJlpBW3pwu1rnqz 677GlAMqDfuQHcxybDsOR3Egi83sovmKYT8XNfxUORgysA6X0KiqFxB7yRfEsegG09 qhfw5GP23VE7A== Date: Mon, 25 Oct 2021 09:54:02 +0530 From: Vinod Koul To: Dongliang Mu Cc: Geert Uytterhoeven , Yoshihiro Shimoda , Laurent Pinchart , Wolfram Sang , Zou Wei , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe Message-ID: References: <20211020143546.3436205-1-mudongliangabcd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020143546.3436205-1-mudongliangabcd@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-10-21, 22:35, Dongliang Mu wrote: > In rcar_dmac_probe, if pm_runtime_resume_and_get fails, it forgets to > disable runtime PM. And of_dma_controller_free should only be invoked > after the success of of_dma_controller_register. > > Fix this by refactoring the error handling code. Applied, thanks -- ~Vinod