Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] x86: of: Kill unused early_init_dt_scan_chosen_arch()
To:     Rob Herring <robh@kernel.org>, x86@kernel.org
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>
References: <20211022164642.2815706-1-robh@kernel.org>
From:   Frank Rowand <frowand.list@gmail.com>
Message-ID: <d3013783-b5b6-6a60-17c1-4bd65004dd5e@gmail.com>
Date:   Sun, 24 Oct 2021 23:26:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211022164642.2815706-1-robh@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/22/21 11:46 AM, Rob Herring wrote:
> There are no callers for early_init_dt_scan_chosen_arch(), so remove it.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: x86@kernel.org
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/x86/kernel/devicetree.c | 5 -----
>  include/linux/of_fdt.h       | 1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 3aa1e99df2a9..5cd51f25f446 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -31,11 +31,6 @@ char __initdata cmd_line[COMMAND_LINE_SIZE];
>  
>  int __initdata of_ioapic;
>  
> -void __init early_init_dt_scan_chosen_arch(unsigned long node)
> -{
> -	BUG();
> -}
> -
>  void __init early_init_dt_add_memory_arch(u64 base, u64 size)
>  {
>  	BUG();
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index cf6a65b94d40..cf48983d3c86 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -65,7 +65,6 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
>  extern int early_init_dt_scan_chosen_stdout(void);
>  extern void early_init_fdt_scan_reserved_mem(void);
>  extern void early_init_fdt_reserve_self(void);
> -extern void __init early_init_dt_scan_chosen_arch(unsigned long node);
>  extern void early_init_dt_add_memory_arch(u64 base, u64 size);
>  extern u64 dt_mem_next_cell(int s, const __be32 **cellp);
>  
> 

Reviewed-by: Frank Rowand <frank.rowand@sony.com>