Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans
 multiple pmds
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Russell King <linux@armlinux.org.uk>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ard Biesheuvel <ardb@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20211020054942.1608637-1-quanyang.wang@windriver.com>
 <CACRpkdYxMDp4FRGP=EOt8oTMxs_YuskbvMx5wXBDjUWz6hD=gQ@mail.gmail.com>
From:   Quanyang Wang <quanyang.wang@windriver.com>
Message-ID: <c1ffbda7-812a-cfbc-8cea-225a5c8570c4@windriver.com>
Date:   Mon, 25 Oct 2021 14:38:00 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CACRpkdYxMDp4FRGP=EOt8oTMxs_YuskbvMx5wXBDjUWz6hD=gQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3hjUmMzUGQvMWpvV016VUlvTVZIeWtJdnBXU3pXRFIrbFZPZ1VPaG5UR0gv?=
 =?utf-8?B?R0s2MFhhZ2ZRR1QvRXFwZEdETDBEYTlEaWwyczRDekkyb2tBL0tzanpOSnJ6?=
 =?utf-8?B?RDRRSE5LcmVYM1ZieVkwUVIzcXFLS0lJbjJsdXpQVTR4SmpRNXhVUlluSy80?=
 =?utf-8?B?d3NHcjRjcHVQUVUrQzcvKzVwZFUwdkVyaVZ1a3p0U3o5akJlaE5YTWlPcjI1?=
 =?utf-8?B?VzRFSUpaeFA1ZFVxeENEcFhrV0ZicHZTUTQwaUZUdmVERkY0V0FiNWJscEI2?=
 =?utf-8?B?SmNkNHVjOEx2TUFadXVGMTZDbkUydENhcytuVjU0QjVZcmRGbmhpWnpveW5h?=
 =?utf-8?B?eG9zdWd6ZnhKS1Z2TDVxTnYvY3JwRm8yNy9yR1AwcU00RExkS1RIdWdldTBx?=
 =?utf-8?B?QTgrejFrZVRKRWkrckQ5M0Vwd1NqczdvMjAwU2FUN2phSkpyODBRQy94eFBU?=
 =?utf-8?B?Wk1hNVlwNEVVVXVCazlBMVBId1ZQMWVKdlBGVFowcFI2cVdMUldXSmRLb3JR?=
 =?utf-8?B?bit2UlMvRmtDaVpiYzFNcDhKRTIrcVMxR0dwdk1OYVNsSmZjMThySEFhMmNI?=
 =?utf-8?B?SzQ5V1pTTnFiYUVVTGphZGp3Y3l4QWV5c1RzOVZCcjNsV0tEYXlJamJQTnNQ?=
 =?utf-8?B?Zi9XeDh6bDRjd2VqbEJ1OUg0b2lUZjJmQ3FHUU5iNmp3WHVjS3kvRHJzUGZx?=
 =?utf-8?B?cTVkZzRUaFU3VVhqdTdUY2lYbFovWnA5TmFJQmhqcEhLUHAzWEozdmFhV3V3?=
 =?utf-8?B?eXdJUnZaMTJUNFZoREZYRkFySTNCVjZhNDJhNXpONGNOS1poOXk2RGYvODFL?=
 =?utf-8?B?K0NOZUtRWUFibHBiK3RxVldCenN5YVdRNk4wOURPOXRlci9aQmJadmVJYnZB?=
 =?utf-8?B?d1phcWNWVHF6WnBBTkh5YXdTMW84eW01K3hVR0NpOWNxNmF6K2tWYSsyMGFR?=
 =?utf-8?B?ZU0vM1BYb3FMSFYzS3ZIMjFpNU1SaHBxQW9PZnphVzBYRDJlSmlSOEQ1Y1FE?=
 =?utf-8?B?c2txNnJvRmpGVStFUkRSdGJHRTJ2UWQrTkx3eWJrcnBiNnZRRUNUa0ZBS1kr?=
 =?utf-8?B?YktMcGVwL082YmNoa0RzU3hUQVQyaE93Nk13aml6Y0VlUXdJaTgwRlNjQzg1?=
 =?utf-8?B?aEhkb0ExY0VuZktZTmZMcWJCMlJWc1MzU0JoOWh6aUtGakdaeUZTL1AvQ1Er?=
 =?utf-8?B?S0hrVHMyNXlMVVlIWmNIVzQ4YzVQUmFTZUF4ak9GSUZMZEVYcmpjNmlqbis2?=
 =?utf-8?B?T2pKTWNQTUdUQXIzTy9YeGZjdktCUktZTjYxb3BKOFplSzlzVHJsQzNmZ0pR?=
 =?utf-8?B?bkxPWWJzTTUxeFJVK2NWaHNSUWhpTit4ZDlkUmxwN3ZjcGJLcWhybkd0aUFS?=
 =?utf-8?B?NGc1bjUzcWlzc0ZNMnRVZ3c5UDVOME1lQmI1VE5nZHRFNHd3b2didnNQUWxi?=
 =?utf-8?B?Q0toWkpzOGJIZXhkYjdwUHVmU3duNGdqcDRmd09oZWFOWjVuMjlLVUk5YnlT?=
 =?utf-8?B?YnlwUGZTMWJYamZ6cVNRZ0lpYkk0TlpoQ0NwMlpYTS9aWGZUMHVZVlpVcllY?=
 =?utf-8?B?VTNEOFljay82RlFnZ2JxNjhOMFJrLzdwV3NOZ21BbmxnSnpJY1hTQTJxTC9l?=
 =?utf-8?B?Y3MrTlpkVVpIbGkyOGo0M0w1KzhDZ05yZWFGWDIyd2R3OHhBVm50QXJOTkhU?=
 =?utf-8?B?UXBZdk1rYUdBZmlKbHhZczg2aG1NZHBGd0RHdGpvdVNZWHgvSFpmbW1RaEJE?=
 =?utf-8?B?VkFHTnVmdE8reFdaR2ZtenU3YkJNOTdJTHExajcvYzZLQUdTYXUyVUgrZVU3?=
 =?utf-8?B?MG0rTkw4Z2VHdlcyRlNTT0k5TmxrZFczNlp0Qllkenk3c3lVZkRrRzgzaWFy?=
 =?utf-8?B?b0JDaWpmL2Z0U1B6T29uYzUwSi8veGNYdmxzS1pIQ25JVXplN3p1U0JkNTZ4?=
 =?utf-8?B?TG8vaWY3YU5lYjMrWCtZdFRCRlgwbFc4L1FTaFlsQUNTcUhJSUxrZmtQS1Zl?=
 =?utf-8?B?WXYzOFRNS0xOMzMxdFZ5bzk2WXoyWklHVDd6RUpnVy9zaUNIYVZzZ3Z2dnJF?=
 =?utf-8?B?S3g0ejRXWlAvOENRcXpzdk1jcERKSklIRFRvNG4wcHBibGc2MXFVV1FmM0Rh?=
 =?utf-8?B?T0J2clBidEl6d2lTUUhEV2JDaEx2TnNGYjFQa3FDMm5xbE9abFJJd1pKUDJY?=
 =?utf-8?B?YnNMR3FvYWVia3BERFdJNjA5QWRmY3MxY1lJNnFtaFg2TVJkbzRqQWhCdXcw?=
 =?utf-8?B?dWt0Y0x4ZHJiQmRlelo2dlJhYmd3PT0=?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2e6196e-96d1-4e38-238b-08d99782022f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2021 06:38:08.9435
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WasA7INy23rh3s872cQNMhVMpq2JDlLEoFxWWek8Meb9VXC+0WgClSA+71Torvki/zJf3euyqy+FElGLVf8ygIfeCJIk47c1U0p/Zl4PSBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4808
X-Proofpoint-GUID: Z2SizulSgaVcMX5q2FwK_aCEVhdsyj-X
X-Proofpoint-ORIG-GUID: Z2SizulSgaVcMX5q2FwK_aCEVhdsyj-X
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-25_02,2021-10-25_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=818
 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 spamscore=0
 impostorscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 mlxscore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109230001 definitions=main-2110250037
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/25/21 5:44 AM, Linus Walleij wrote:
> On Wed, Oct 20, 2021 at 7:50 AM <quanyang.wang@windriver.com> wrote:
> 
>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>
>> Not only the early fixmap range, but also the fixmap range should be
>> checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM,
>> some systems which contain up to 16 CPUs will crash.
>>
>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> 
> Looks reasonable to me.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Please submit this patch into Russell's patch tracker.
Done.
https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=9149/1
Thanks for the review.

> 
> Yours,
> Linus Walleij
>