Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 12:13:37 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Xin Xiong <xiongx18@fudan.edu.cn>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        yuanxzhang@fudan.edu.cn, Xiyu Yang <xiyuyang19@fudan.edu.cn>,
        Xin Tan <tanxin.ctf@gmail.com>
Subject: Re: [PATCH] drivers/dma: fix reference count leaks in mmp_pdma_probe
Message-ID: <YXZSGe+BBbXEiXg3@matsya>
References: <20210911070533.3114-1-xiongx18@fudan.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210911070533.3114-1-xiongx18@fudan.edu.cn>
Precedence: bulk

On 11-09-21, 15:05, Xin Xiong wrote:
> The issue happens in an error handling path. If
> of_dma_controller_register() fails, the function simply prints error
> messages and returns error code, without decrementing the reference
> count of pdev->device incremented earlier by
> dma_async_device_register(), which may result in refcount leaks.
> 
> Fix it by invoking dma_async_device_unregister() before returning the
> error code.

Pls use right subsystem tag, git log will tell u the same. I have fixe
dit up while applying

-- 
~Vinod