Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4285334pxb; Mon, 25 Oct 2021 00:57:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiaYqGKiIfPGqp37PCggDwHbZjXFs7DARxBKdXINt11nlkHn8BTiBuDPr6sM51jNmNuwyC X-Received: by 2002:a17:907:3f1c:: with SMTP id hq28mr20875521ejc.139.1635148628970; Mon, 25 Oct 2021 00:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635148628; cv=none; d=google.com; s=arc-20160816; b=fs9EuRWCwtUBTChonSMO03DD7QgP5YdtlLYEaUj+p6+lSAlyOuJMZCQ+EWF6qAqftL ZVRjThtOELgab6G8aHLZ2vA1EipbnueBA43n1YomQZuBW6JOvBQkhHMmznBGltiiJysQ eVIjQFa51bE+L6FMr3CNpElXWRx25M/C2gsofw5gTLopDn3F7V4J4ns6Q+8vphCrrEKs J8KY23/cOLcZa6taQIaLLcx3Pfllcu4DLsWBhVBLx39Es3y+b9p8gQ2XCkTKYS5UhjaH HWrpQ7sGeqx33nvpieSUI3/vlrLS8X5bRo5YhQ8uBMvI/jCbX1RkWvoG8eySeKDlZDl4 w6QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=G0GzP4CdbaIV7wFO3Y6i3/e2qh0tFgM/KAgUrXZqNDI=; b=0edKO19IO5i1XA0tWNDcGFrzMWPN6IERdn4RTBhQzLQlynSToqvYFrIk2pSu9kEhaG vKTvpOSpIRNYi8cocLvM5KMAXyCJCA3PEC7TiL5pOs6/oB9C8fu9gdK2fxx1qHkYeKzT 0lCWR8PkY9TaMi7UiFKL6XPIIPapsJUONE6j5DH8Ae1MMNW4LMWxsoW2/Uo6fUJ97PyQ NktztLgnem9PoWw4+nh4EnpT8fkVXAsnHID8lGUHwHsOhKADHVipeUWi/fX8r+sF2vjs qLoauEVf5KJcFhjHhf7z05d4Cm7AaPkzl1j7bKaHz/hZ3Ah1DGTyQtwUgVC6WW2mCaaE 5wzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d5EA80IB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ne14si30773858ejc.451.2021.10.25.00.56.44; Mon, 25 Oct 2021 00:57:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=d5EA80IB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230169AbhJYGnF (ORCPT + 99 others); Mon, 25 Oct 2021 02:43:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:47736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbhJYGnF (ORCPT ); Mon, 25 Oct 2021 02:43:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 894CD60EE3; Mon, 25 Oct 2021 06:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635144043; bh=HmciNwUjNQsLVm5p4hbdYC9XYTU4foPEhTLhvcaReqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d5EA80IBy8bXgoaSDLynZFrfs46O8yaDIdJG9aY8CZKYucM/JW0UEA3lmxw6PznaI Otz6FSAhHdXym/19CwFBBTj/Loaeqpq43R1v0YkTmYwDWyjnMiwQw4b6otHEtlLPMp M383Igli+c79PKd6le48WQH3kJIL2JkC8M8G4eQIK/sVsNoPliKan6rxCart+C3mGa t2FurW56m5B1N7CXQ6zHv69nP7wS0CTsM2zyYzb1ullk05Px6kJbjIzChShU1nGryg QwUAbcEy1wbvi5rD5sX/25gW/+fzzmzCYYTrTifJCIZC7DAYwjMpf1VhydI8Z5U0+R TG5Z5/mv0I+fw== Date: Mon, 25 Oct 2021 12:10:39 +0530 From: Vinod Koul To: Cai Huoqing Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: sa11x0: Make use of the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() Message-ID: References: <20210828090117.1814-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210828090117.1814-1-caihuoqing@baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-08-21, 17:01, Cai Huoqing wrote: > Use the helper macro SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() instead of the > verbose operators ".suspend_noirq /.resume_noirq/.freeze_noirq/ > .thaw_noirq/.poweroff_noirq/.restore_noirq", because the > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a nice helper macro that could > be brought in to make code a little clearer, a little more concise. Applied, thanks -- ~Vinod