Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4290107pxb; Mon, 25 Oct 2021 01:03:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1MulkkFMZA/vhwR6+CYYI2SZV5a3gPl/yZuu7NpnE3/WGvXFzu6haebv+zyHjNLAfYHBQ X-Received: by 2002:a17:906:a0d7:: with SMTP id bh23mr20052250ejb.82.1635149032334; Mon, 25 Oct 2021 01:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635149032; cv=none; d=google.com; s=arc-20160816; b=Wqw34sPTP9sWzWzYmh5nmBCXsTrluDEpgFrmAWjlxY+b0cG68EG8ZF91qOxcX3reJ0 HDSz+nzmSS0/JiIn3rIkwRtUL8IUVyer1Kiai3fbY/IZwdXSVdz4H6rpBsXwk0ZoJXcR /PsrRmb0c6QNGC1/xlHMg6zX5RLYQkMEIyjKitTdzkG5qvKGOhfUTGjlpKWxhv3VJdaf 5MbWTNy/V7LU8cDTlmx+XSNQlzqOWsqBObEkA//NI+bUdNrss9tfoBEANAkDwC85VRrP uAuJHoypAGzaOxfkny5/lIQ0VCIF824F33dBXmIw5lOymsuyV40LE3sxcF1f9L/S4/TF I0HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kvG8tf7suplztZCQTyRQr+c+3zoLZICOLqbzwneF/D8=; b=jl/ICzcBZY98NXlgjPSjmUamkjm/wp/59krkDsFV2/IMBRSEPcgl5wMxAO834lZRJ1 Tfj9DEq4xPs0CbvexSMUen0EfQj3qKIyonYUTn1/Ehi2Ig1gzf9pzufyCtrhtL0O1hu+ 8TH3h0lAVDFD6dqoE73Ip7KmJK08nlaSnl78lpaCEZF21IO0x+P++YKHLmDsWbHCIbwL VsepsLps1k3LhWPS/W0eWO1mnx6eeZhAjYpoK+UvoMQDwWb2hEtTcjLUH9Lr9epS6I46 VAEh4QpuvN4q9mXPod2DHHmCwjFYJtLShSkO524H8BVYlsBZy0IbNvUX8bbCdQCCeObd jCqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="lOBd/kIb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds7si21778532ejc.362.2021.10.25.01.03.29; Mon, 25 Oct 2021 01:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="lOBd/kIb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbhJYHPp (ORCPT + 99 others); Mon, 25 Oct 2021 03:15:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:32882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbhJYHPn (ORCPT ); Mon, 25 Oct 2021 03:15:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4FC236008E; Mon, 25 Oct 2021 07:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635146001; bh=ZwPIhP5Fum4SkSbAuDdcea+11cJeBGh0IzPYNZOWN2c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lOBd/kIbQHtMM/lhGRgXb34HCMMWKHqZ8O3gcTZGLfZyZhIqBOH0LoqY29N3U9w8m sdxSnBu/xq85wp7NSIOtboRRyyDcWsaEDnhtFYQjfWy45BzicSkhzP5m5WKArR1Eki B1ttumMRqyc4rGUft0G1mlxdoRlCcqBPIdb+7f1XOZS03Adc1ccN0eijLShq1Dibre RZ3WRV+c7oYsL5SinoyLXzHLkhvWVEHoNMhNJ6Ze2mrbOdbs2zeO071v957dIlDTO5 eEIiXf8W6UHeMdJfZVIkv8Z2mkbUvbYnwUYPGTmIpEUA7IzR21HGpOSUOtqZhCn1WU Aky5DoH++XHIg== Date: Mon, 25 Oct 2021 12:43:17 +0530 From: Vinod Koul To: Sandeep Maheswaram Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , Greg Kroah-Hartman , Wesley Cheng , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com Subject: Re: [PATCH v2] phy: qcom-snps: Correct the FSEL_MASK Message-ID: References: <1635135575-5668-1-git-send-email-quic_c_sanm@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635135575-5668-1-git-send-email-quic_c_sanm@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-10-21, 09:49, Sandeep Maheswaram wrote: > The FSEL_MASK which selects the refclock is defined incorrectly. > It should be [4:6] not [5:7]. Due to this incorrect definition, the BIT(7) > in USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0 is reset which keeps PHY analog > blocks ON during suspend. > Fix this issue by correctly defining the FSEL_MASK. Applied, thanks -- ~Vinod