Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200924063042.41545-1-jhp@endlessos.org> <YXXNsdVTo8pVfs4/@think.localdomain>
In-Reply-To: <YXXNsdVTo8pVfs4/@think.localdomain>
From:   Jian-Hong Pan <jhp@endlessos.org>
Date:   Mon, 25 Oct 2021 17:04:20 +0800
Message-ID: <CAPpJ_ed1pBmCWPFMPj8vNkfPAqUtugvUJC14e2pcDuDJUastzQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort
To:     Siva Mahadevan <me@svmhdvn.name>
Cc:     Rob Herring <robh+dt@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
        Soeren Moch <smoch@web.de>,
        Tobias Schramm <t.schramm@manjaro.org>,
        Johan Jonker <jbx6244@gmail.com>,
        Katsuhiro Suzuki <katsuhiro@katsuster.net>,
        Hugh Cole-Baker <sigmaris@gmail.com>,
        Robin Murphy <robin.murphy@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux Upstreaming Team <linux@endlessm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Siva Mahadevan <me@svmhdvn.name> =E6=96=BC 2021=E5=B9=B410=E6=9C=8825=E6=97=
=A5 =E9=80=B1=E4=B8=80 =E4=B8=8A=E5=8D=885:17=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Jian-Hong Pan wrote:
> > The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
> >
> > kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* mi=
ssing extcon or phy
> > kernel: cdn-dp: probe of fec00000.dp failed with error -22
> >
> > Then, the device halts all of the DRM related device jobs. For example,
> > the operations: vop_component_ops, vop_component_ops and
> > rockchip_dp_component_ops cannot be bound to corresponding devices. So,
> > Xorg cannot find the correct DRM device.
> >
> > The USB type-C DisplayPort does not work for now. So, disable the
> > DisplayPort node until the type-C phy work has been done.
> >
> > Link: https://patchwork.kernel.org/patch/11794141/#23639877
> > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arc=
h/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > index 06d48338c836..d624c595c533 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > @@ -380,7 +380,7 @@ mains_charger: dc-charger {
> >  };
> >
> >  &cdn_dp {
> > -     status =3D "okay";
> > +     status =3D "disabled";
> >  };
> >
> >  &cpu_b0 {
> > --
> > 2.28.0
>
> I saw a similar patch posted at https://lkml.org/lkml/2021/7/15/752. I
> was wondering if one of these patches will be submitted to mainline, or
> what the status on this patch is. I can confirm that this does solve
> the issue on my Pinebook Pro. Will this go forward?

Notice that commit ("arm64: dts: rockchip: Disable CDN DP on Pinebook
Pro") [1] is already in linux-next.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/com=
mit/?h=3Dnext-20211022&id=3D2513fa5c25d42f55ca5f0f0ab247af7c9fbfa3b1

Jian-Hong Pan