Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp4333205pxb; Mon, 25 Oct 2021 02:10:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyHw2H77YScb9+PlVg9XFlbppYIcqNjDooPJMn6q7mm7gLGfg9Xl8r8zFLomZwJzAiqHt4j X-Received: by 2002:a17:907:1607:: with SMTP id hb7mr16403857ejc.79.1635153049964; Mon, 25 Oct 2021 02:10:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635153049; cv=none; d=google.com; s=arc-20160816; b=JeQU8k/7g/2y20bzVz6K7hlsqt9VuKQ9INjEUQmmcVqflDFYGMNOcHoCeSNg5Uw88k 7bcF2arTwAVbgrIAJufqfywQXd6c/Vb3GpHvzSGhntmBbO9xBX55YoXjJmeUPj1pDl+u WkM0cKX1gvCecYk6Lje/k5CzTQ11mSr2Plry5x/2E8S5bzsulvBPOR+kiU6JeIDTAdis /7KPSvUkVvvp7YBhKG3lLZ6yG8I4D3tNLnwTFtaMpHLSYkdhZKPSVvPzKd9j9T0bJRzg lHDhT5xuyDgSRIEP5QNP+I4L/kDSgCeQQS7BlszBzmk4bFHEyaGvWJdnQFRIYAEBpdGi YWqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eLz6CvSAHIZYP8bX5Q/PFMo/fENVcXDR/Xri+Pjzzgg=; b=Yab1XKDa1prmr750HFN1tuiPizUSLHH+Ji6zz8fHYXPnhwFvV5IvIoVegmNLuy/eOt GWEoRVISskPuDguzzT8xZpxhHXR9WskWI/e+TS5P/OBz0VFsZreVrX7FgVvRhnDSVf20 N0fqUXOO2XewmeF0y/Eqg3AhG0BVXYqpF6I9GY9QL47js7s4ElBisYYlr0mka/KaziG9 fUT5kPiT9xazFW2MKMCpUbOPu89r7b89MF/M82/sLwmZFahLp0QtIeBHNnA7Ye3v/+sr 8525B/IS81E8TRwMg2x7YHsmBFAcSCJqYpmoruZSroHUCA+qWsKsysEFhZozdhS8r51U q3gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lxakpkQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y5si24369509edp.123.2021.10.25.02.10.20; Mon, 25 Oct 2021 02:10:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lxakpkQB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232401AbhJYJJG (ORCPT + 99 others); Mon, 25 Oct 2021 05:09:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232346AbhJYJJC (ORCPT ); Mon, 25 Oct 2021 05:09:02 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70917C061745 for ; Mon, 25 Oct 2021 02:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eLz6CvSAHIZYP8bX5Q/PFMo/fENVcXDR/Xri+Pjzzgg=; b=lxakpkQBtB0ZzLg221DYurGYT/ VHfg9ZFhBUSdxktwfUTFFL//vfhocGaaG4l0rWwVeGrdmORL74wGPZVwTU8ufSA9zmg7ARl8QhdYJ mq7IF7dInn16romov2GduSAvBFhbqSyN+WeZ8qnK6e0jlko5h016gN0zi0OyMDdaEkOQ+h6x/rLS5 lAmYtndESBZB75IedhNpBvhzBPCxqg6ecAPBebAbJkpIa8VuS0Lf9bLqJjfZuIqdGx9VPkIqB3zc5 F+PLPg/ieC1htqxjS5dFj+Nnkx4fJL3QY6DoQJhLoPHN8iBxLUwHXh93yuFUJgr4lzoSAgKSSzgmw +TRWO5tA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mevuE-00FyME-PP; Mon, 25 Oct 2021 09:05:04 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id CC94C3001BF; Mon, 25 Oct 2021 11:04:33 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id AF4C720C6C14E; Mon, 25 Oct 2021 11:04:33 +0200 (CEST) Date: Mon, 25 Oct 2021 11:04:33 +0200 From: Peter Zijlstra To: Rob Landley Cc: Josh Poimboeuf , Masahiro Yamada , "linux-kernel@vger.kernel.org" , Andrii Nakryiko Subject: Re: Commit 0d989ac2c90b broke my x86-64 build. Message-ID: References: <53f767cd-9160-1015-d1b8-0230b5566574@landley.net> <20211024192742.uo62mbqb6hmhafjs@treble> <66ed460c-ac48-2b5a-e8e4-07613cf69ab0@landley.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66ed460c-ac48-2b5a-e8e4-07613cf69ab0@landley.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 24, 2021 at 09:51:45PM -0500, Rob Landley wrote: > > Unfortunately I think CONFIG_STACK_VALIDATION is no longer optional on > > x86-64 these days, because of static calls and retpolines. > > Does it need stack validation, or just a frame unwinder? static_calls rely on objtool to find all "call __SCT*" instructions and write their location in a .static_call_sites section. The having of static calls is not optional on x86_64, and I have zero interest in trying to work out what not having static_call() does, or to maintain that option. We have too damn many daft configurations as is.