Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp53814pxb; Mon, 25 Oct 2021 03:46:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKKjlOauBRHlslh/D94R79Q0MQyCXzvqqVj6lkiTeS+x5CbCQ9AJx6aMj5M2eFSN5fTkHV X-Received: by 2002:a17:90b:3ecd:: with SMTP id rm13mr19900452pjb.189.1635158802535; Mon, 25 Oct 2021 03:46:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635158802; cv=none; d=google.com; s=arc-20160816; b=Qg59N8aYFecMM8NxuMOPjFIOgTgC1DF/vKiFSBhLWq9IRomaK+H1RlYXmSMIc5T5A2 AGdGacAOkAdZTN5mQKcPcqI6k3L4o9ejgR3Lw/Kety5IRxG3UDTXgfuD1OGgx45VlgD0 O+494xeBHpE1w8bvDASB4aw5k8YP6BKl1QXgg/bP69se1q2qfZUQciykq7AIr/LYu4gN ii/8W5OFKsMwsYwBwvL4+o/IIlDsv9cxe3UQt2XBUB9cLPOz1/evjdlvKwFH80vhZESt /q4J552JmpS4LOlAm+YIJt7JCQdfgdBeeNeAYa2mviwoWA7ESM1Er0iKYqYaiI/QekSY IVEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JSJcCzBeASxJ7TsOba2UDAmZE1dDqY2+YjhcKEkuqM0=; b=gsSlDwQZmyAKoIupjcucJrjv1gkTC0Kjn4fNf+buRHPUvrjozxofeFJ924WYlXi4KM CxlNPtDsN7/+zHKpErIK/ugA39kE/A5ebXcMPyhFLtk/IrbVGvgVYAuZ4AN8Bu3SCEJX oqbirRzodpg0JizPw7bQf/OWLV+C6mRaXfb1ifWd6+vHz0WWyrrrW6jVX2kjpeEeKbfS oSOHdhPRDhSpKg/34YJqdlD8eTDopAFIxGDCCJcKCbZjUB6Co37wg/M7AKOzCGZtEUF6 v59j2fMYrDBsTbJKs4DBmEv3vfVk8gztQvxJRLUlqafWQsEE+YHq2XzaG5ilZDwfRb7q uGqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=it3E4cth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si25350429pfd.331.2021.10.25.03.46.29; Mon, 25 Oct 2021 03:46:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=it3E4cth; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231448AbhJYGsR (ORCPT + 99 others); Mon, 25 Oct 2021 02:48:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:50088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbhJYGsL (ORCPT ); Mon, 25 Oct 2021 02:48:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8AB0C60EE3; Mon, 25 Oct 2021 06:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635144349; bh=7+3Z11f0cDWTPdg3Z01O1Q1dpJslpStItpjZGPBcBMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=it3E4cthtYvRPJmDDPgZLfo5QFVgL8/q2XH7R1kMn8oSQSCyVrpm5cc9/ZJ/+Sq7F Dc5lzoZTUuvM3udDK4HLxJN3qlUcqNMlU2U7QwOTtUVMot5u6BbbqZroxoCbx4tmvG UJjpd0kZC2/E5wDBrg70/adTgJJmSCFOkfnv5x6LVDHSfB9weMX6WTXtqpdfSGB/HU Si/o4wNCilW1GlEQrFoKYN2ju1GemnzYmbSq7denBkEQgOQOc4reNetHWW0iovmPBD i9fYbRpVF8mgUNivki1pEa6z/9SNPEJmycj1dgLKvnSA9AfyIRuPNmMbjVFNTk9ecO kW6RypDb8JuAA== Date: Mon, 25 Oct 2021 12:15:45 +0530 From: Vinod Koul To: Colin King Cc: dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] dmaengine: sh: make array ds_lut static Message-ID: References: <20210915112038.12407-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210915112038.12407-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-09-21, 12:20, Colin King wrote: > From: Colin Ian King > > Don't populate the read-only array ds_lut on the stack but instead it > static. Also makes the object code smaller by 163 bytes: > > Before: > text data bss dec hex filename > 23508 4796 0 28304 6e90 ./drivers/dma/sh/rz-dmac.o > > After: > text data bss dec hex filename > 23281 4860 0 28141 6ded ./drivers/dma/sh/rz-dmac.o > > (gcc version 11.2.0) Applied, thanks -- ~Vinod