Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp76056pxb; Mon, 25 Oct 2021 04:14:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydql0qPyw3r5aDS9ElA+FvU6LEN/H3sp8E4HBx7KALlb0XYNJLyvRgpWN/e1DIZ2cJ0EUq X-Received: by 2002:a17:906:2f16:: with SMTP id v22mr21617845eji.126.1635160487712; Mon, 25 Oct 2021 04:14:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635160487; cv=none; d=google.com; s=arc-20160816; b=ecqFox4E2aQNsUAOKOcKp6v6VjQeELQm/kU9O5WhZN7qQoGBfGkIw8QcjXKBNA7sAt xM334IUqLcAun23P+DcL8OV/uUEjZtNiHqxz3dTib+rf/FWzVJz+aUEx1zL+fwg3JZ1O Mxq9M54XGOaGtie0qugpZTGKeoA0Pl5uAm5vhCvrP101GPamtyLa67lVSW4OI0KeSWOz +0LzFZmLkgklFpV7vmpiqcQPwW7a4iLN9DWPGo9//cYi/5J6lqwwscpheZWjISEGUuTj NoCrqXLPWTaT9sAkuNvVqzR32G09nmKcrwOPruauAKwpn3ZFefGkMkDzwUGrzy4mPWHB nhpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=SIRvkxF8ZwehFmJrFZfQMFi1GpjnkGGYuVlPQrRK/7A=; b=OwdTjc212vU5MYbYpc2PNr2Ay4+Ty9s2hD5bArozqLmU5V6piZ8AUNpwsCJTQ5GiDC iCLI1zKrKK4r7Pq32TOKQK6yfgJb1ZgLb+90lemzzMqN+IR1KRPWKGOFGp+KZpLtzOGD nsw4gVOgNMYnam2PY9mLOQ5y8hZqNit03GsEjRCOI4S3zF20D3X9Kb9A0T2ip2mhXFuX WqVPxXojVriByAIqmzWwcYz9lxWVB8cRdmV3AOGJl/F17mQ/GCsRStW5HkzXz4ph+vqx ogGkKYN0VAjvvcT3x7wM4Qr/JgvSJFomhUv2ikJwKxwaQD6iY12bzM1jfQkJyiL0nLvH 6mMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hc40si14701614ejc.188.2021.10.25.04.14.24; Mon, 25 Oct 2021 04:14:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhJYIED (ORCPT + 99 others); Mon, 25 Oct 2021 04:04:03 -0400 Received: from mga17.intel.com ([192.55.52.151]:44469 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhJYIEC (ORCPT ); Mon, 25 Oct 2021 04:04:02 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="210373631" X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="210373631" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 01:01:17 -0700 X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="446531190" Received: from dscaswel-mobl2.ger.corp.intel.com (HELO [10.213.242.254]) ([10.213.242.254]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 01:01:14 -0700 Subject: Re: [PATCH] drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR To: Kai Song , jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com Cc: airlied@linux.ie, daniel@ffwll.ch, jason@jlekstrand.net, thomas.hellstrom@linux.intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20211022120655.22173-1-songkai01@inspur.com> From: Matthew Auld Message-ID: Date: Mon, 25 Oct 2021 09:01:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20211022120655.22173-1-songkai01@inspur.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/10/2021 13:06, Kai Song wrote: > Fix inconsistent IS_ERR and PTR_ERR in i915_gem_dmabuf.c > > Signed-off-by: Kai Song Pushed to drm-intel-gt-next. Thanks. > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c > index 4a6bb64c3a35..3cc74b0fed06 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c > @@ -102,7 +102,7 @@ static int igt_dmabuf_import_same_driver_lmem(void *arg) > obj = __i915_gem_object_create_user(i915, PAGE_SIZE, &lmem, 1); > if (IS_ERR(obj)) { > pr_err("__i915_gem_object_create_user failed with err=%ld\n", > - PTR_ERR(dmabuf)); > + PTR_ERR(obj)); > err = PTR_ERR(obj); > goto out_ret; > } > @@ -158,7 +158,7 @@ static int igt_dmabuf_import_same_driver(struct drm_i915_private *i915, > regions, num_regions); > if (IS_ERR(obj)) { > pr_err("__i915_gem_object_create_user failed with err=%ld\n", > - PTR_ERR(dmabuf)); > + PTR_ERR(obj)); > err = PTR_ERR(obj); > goto out_ret; > } >