Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 15:03:05 +0300
From:   "andriy.shevchenko" <andriy.shevchenko@linux.intel.com>
To:     "changlianzhi@uniontech.com" <changlianzhi@uniontech.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        "dmitry.torokhov" <dmitry.torokhov@gmail.com>,
        gregkh <gregkh@linuxfoundation.org>,
        jirislaby <jirislaby@kernel.org>, 282827961 <282827961@qq.com>
Subject: Re: [PATCH v6] tty: Fix the keyboard led light display problem
Message-ID: <YXac+bpVemXEp9XR@smile.fi.intel.com>
References: <20211021020511.18016-1-changlianzhi@uniontech.com>
 <YXLVAOh6AcB34kW8@smile.fi.intel.com>
 <202110250129181502896@uniontech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202110250129181502896@uniontech.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Oct 25, 2021 at 01:29:18AM +0800, changlianzhi@uniontech.com wrote:
> >>On Thu, Oct 21, 2021 at 10:05:11AM +0800, lianzhi chang wrote:
> >> Switching from the desktop environment to the tty environment,
> >> the state of the keyboard led lights and the state of the keyboard
> >> lock are inconsistent. This is because the attribute kb->kbdmode
> >> of the tty bound in the desktop environment (xorg) is set to
> >> VC_OFF, which causes the ledstate and kb->ledflagstate
> >> values of the bound tty to always be 0, which causes the switch
> >> from the desktop When to the tty environment, the LED light
> >> status is inconsistent with the keyboard lock status.
> 
> >...
> 
> >> +	unsigned long leds;
> >> +
> >> +	leds = (unsigned long)ledstate;
> 
> >Can be one line.
> 
> >But most important question you are ignoring to answer / address is why do you
> >use casting?

> >>But most important question you are ignoring to answer / address is why do you
> >>use casting?
> Casting is used here because:
> The second parameter of test_bit is "volatile unsigned long *addr" (see constant_test_bit() in /arch/x86/include/asm/bitops.h), but ledstate is an "unsigned int" type. If casting is not used,
> compile Will report an error.

Wait, you are casting pointer to an integer?!
This is completely wrong in this case!

-- 
With Best Regards,
Andy Shevchenko