Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 12:23:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Francesco Dolcini <francesco.dolcini@toradex.com>
Cc:     Richard Zhu <hongxing.zhu@nxp.com>, l.stach@pengutronix.de,
        bhelgaas@google.com, lorenzo.pieralisi@arm.com,
        jingoohan1@gmail.com, linux-pci@vger.kernel.org, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
 came up
Message-ID: <YXaTxDJjhpcj5XBV@sirena.org.uk>
References: <1634886750-13861-1-git-send-email-hongxing.zhu@nxp.com>
 <1634886750-13861-4-git-send-email-hongxing.zhu@nxp.com>
 <20211025111312.GA31419@francesco-nb.int.toradex.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CF3LIB8sPBws0Sny"
Content-Disposition: inline
In-Reply-To: <20211025111312.GA31419@francesco-nb.int.toradex.com>
Precedence: bulk


--CF3LIB8sPBws0Sny
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 25, 2021 at 01:13:12PM +0200, Francesco Dolcini wrote:

> Hello Richard,
> please see this comment from Mark,  https://lore.kernel.org/all/YXaGve1ZJq0DGZ9l@sirena.org.uk/.

> > +		if (imx6_pcie->vpcie
> > +		    && regulator_is_enabled(imx6_pcie->vpcie) > 0)
> > +			regulator_disable(imx6_pcie->vpcie);
> >  		return ret;

I should probably also say that the check for the regulator looks buggy
as well, regulators should only be optional if they can be physically
absent which does not seem likely for PCI devices.  If the driver is not
doing something to reconfigure the hardware to account for a missing
supply this is generally a big warning sign.

I really don't understand why regulator support is so frequently
problematic for PCI controllers.  :(

--CF3LIB8sPBws0Sny
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmF2k8MACgkQJNaLcl1U
h9DE0Qf+JIeGIKboM2eraQaTERFYEtpEhAYiAfvGMwJeGuGFajDRoTyusV2T2/nt
cShDRqgDs31/79zCMl82FADAnvoSK/U7W0+1u3OwvDyUxlZnVur56srCviCHnhqT
7iUvZGT6eeyfkFga56fRe6NIBSEYfDI2/fn2lE1tbAfGbGV0uN809p6DG98g9djP
1lBrQLeGAFdxTchlin5LTKqM5NiFRW2NP+K5XgE9bgj3gUtBMXwhBtAOOJ/TBIoz
eaab9w7nqL38aHx6C+D/Ph0e/WAnIO/1lvY07ntz43PWfk94OS7hixsUS+M7FHPI
hfZMtefyYkk35GlgEpKagbtnP1v91Q==
=p3vs
-----END PGP SIGNATURE-----

--CF3LIB8sPBws0Sny--