Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <e9098c0e-e1fe-5d65-c111-1607d0a6a1a7@lwfinger.net>
Date:   Mon, 25 Oct 2021 10:08:16 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 2/2] staging: r8712u: fix control-message timeout
Content-Language: en-US
To:     Johan Hovold <johan@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20211025120910.6339-1-johan@kernel.org>
 <20211025120910.6339-3-johan@kernel.org>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20211025120910.6339-3-johan@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/25/21 07:09, Johan Hovold wrote:
> USB control-message timeouts are specified in milliseconds and should
> specifically not vary with CONFIG_HZ.
> 
> Fixes: 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel")
> Cc: stable@vger.kernel.org      # 2.6.37
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>   drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

> 
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index 655497cead12..f984a5ab2c6f 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -494,7 +494,7 @@ int r8712_usbctrl_vendorreq(struct intf_priv *pintfpriv, u8 request, u16 value,
>   		memcpy(pIo_buf, pdata, len);
>   	}
>   	status = usb_control_msg(udev, pipe, request, reqtype, value, index,
> -				 pIo_buf, len, HZ / 2);
> +				 pIo_buf, len, 500);
>   	if (status > 0) {  /* Success this control transfer. */
>   		if (requesttype == 0x01) {
>   			/* For Control read transfer, we have to copy the read
>