Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 16:59:25 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     linux-acpi@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Ard Biesheuvel <ardb@kernel.org>, Len Brown <lenb@kernel.org>,
        Ashok Raj <ashok.raj@intel.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Mike Rapoport <rppt@kernel.org>,
        Aubrey Li <aubrey.li@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/4] drivers/acpi: Introduce Platform Firmware Runtime
 Update device driver
Message-ID: <YXbGTS6cLmuNuJiR@kroah.com>
References: <cover.1635140590.git.yu.c.chen@intel.com>
 <6d4a9bc38c1efd2b10955f64629d194c050fdae1.1635140590.git.yu.c.chen@intel.com>
 <YXZTDp3xB9hZdcuY@kroah.com>
 <20211025141111.GA8602@chenyu5-mobl1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211025141111.GA8602@chenyu5-mobl1>
Precedence: bulk

On Mon, Oct 25, 2021 at 10:11:11PM +0800, Chen Yu wrote:
> > > +module_init(pfru_init);
> > > +module_exit(pfru_exit);
> > 
> > module_platform_driver()?
> >
> Currently there are two platform drivers in this file, one is this
> platform driver, another one will be introduced in the subsequent
> patch for telemetry. Since the two platform drivers are treated
> as a whole, they are put into one file. Should I split them
> into two files?

If they bind to different hardware devices, then yes, they should be
separate files as they are not sharing any common code here.

thanks,

greg k-h