Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp577388pxb; Mon, 25 Oct 2021 14:09:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzC6k9ATQGT7rSUiZvH4UoQ2KRGkPjryVMwuKVzo7otnDIBkDv7wSTGDn0bC9IBGegjWBC/ X-Received: by 2002:a17:902:9a97:b0:13e:2da4:8132 with SMTP id w23-20020a1709029a9700b0013e2da48132mr18539286plp.34.1635196172872; Mon, 25 Oct 2021 14:09:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635196172; cv=none; d=google.com; s=arc-20160816; b=bthNwqe4DQgkw/Q/clr65vgsUm2u6UOFoGMEvNeHMuwMNKSbHmBnneJ873AzG7qv38 0W4Q6ZaSN9DAw2xxUBElEJ2Tqq6C7zTJWds8JrOXxNzpbuIQ9nD5CZy0y140DcyNITUF PfhT9GyS6Fkf/VtVfmFz2CvNwSdOFfk9jyzf7iTHh5AJmPCHM6fMCu1MbFu86879GJpt vyoHSWIOBrlof8/qte6LJlCP7kGYqQhe0hVadNFHHBCtlKaf+BJNnq0BzoijbEWPIo5M yHrgPTqhCDc8rvbxu5EVDG/AAw4O1f/8K0yRAx7fp7VYeRSqitPhJpD4WmwL+GpUJee6 rYrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TQztyN+OyqV2EYalpv3OnHEA+p7UGY3ffgQzpyFstrQ=; b=yqZDmqUeMEeNbprxD7zee1W5cimfdKT8Zw2n5fmuewQm0NH9zH2/ySfUHmQri0E8U2 PGiZ+vweZxKQMToJ9XkcyLDWw8EBuBmbg9M1jyu4/0pk4YHei9UB6U/sc78WPb49SMS3 2lofjYQLqASah4O6IgslJJMdMBfyLlNme/dl9OUcR8Yj9nWfmPUCNmF35dFtq/9sJBAH jyRrIBYquop4YD6pqOxd9hMZg92OK9YHrIQZ+hJOduyQMbDkFtNfP44KwXXZ6CqU9D77 E5afpIypWOOgn/zkagaS4orT2pkbkWYW6LjI19XZtGIkBL7e7Ah602/p1mPcIGT3ttdk cJsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jPJwfXXc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q28si27398726pgu.255.2021.10.25.14.08.58; Mon, 25 Oct 2021 14:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jPJwfXXc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232467AbhJYVKI (ORCPT + 99 others); Mon, 25 Oct 2021 17:10:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232036AbhJYVKF (ORCPT ); Mon, 25 Oct 2021 17:10:05 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEDF7C061243 for ; Mon, 25 Oct 2021 14:07:42 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id t184so12179849pfd.0 for ; Mon, 25 Oct 2021 14:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TQztyN+OyqV2EYalpv3OnHEA+p7UGY3ffgQzpyFstrQ=; b=jPJwfXXczwHre/rQIPjK/VoVvO0IuwfH8WIMj2xxEOvALb2VPbYxNoqprq0OQR5nPC o5DyFtXCsBA94PwIkmXaD6fOOn6uzE1vuL8iTIZvpeFHN0NIs19av/f8DymXuOBARNDi 6wKlBs2WwIj2FcUduika3D+VnZO1ueK9qaM2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TQztyN+OyqV2EYalpv3OnHEA+p7UGY3ffgQzpyFstrQ=; b=z/nQqjv6vSUd3/rF6GDNicjMND6ExRIVqhIFPNYq0nZ0U6/AIGQdGAnb6rxk2Ar1C0 prIKWOt+yRy3XfkPNd76qJYPlBtZRRhkpapOcN1SrT8rQZYamcJysz5ud343KZg1//fE b9D6yZ3PcYgJxNj5WEpiqcj8DQJHthkY+UxqDGUBaQAmkMwblHbKht9M/w7rjQ2aulkG vpm6+OJZCMkaMWYIhFqKOmhrfd37eDlJ8vHYHtglpBT5PFHwU5BdTmGIRhJe/CF3WkxR klShsW8bPa1yEWcRf3OTnfUlXQROWd74qVXvru0Iez6+jseq+wR0tpVtCZe5pg/xeEPh YFWw== X-Gm-Message-State: AOAM530JqQaUm1cLSQmKp5xhIvH0KDeUKgWLoRXM8sNHUbDqLCNSimKH cLMl+0mTcnNNJTKJKlYCuAXTrg== X-Received: by 2002:a05:6a00:bc1:b0:47b:f093:eb4e with SMTP id x1-20020a056a000bc100b0047bf093eb4emr8462611pfu.55.1635196062554; Mon, 25 Oct 2021 14:07:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id oj5sm8917184pjb.45.2021.10.25.14.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 14:07:42 -0700 (PDT) Date: Mon, 25 Oct 2021 14:07:33 -0700 From: Kees Cook To: Yafang Shao Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, pmladek@suse.com, peterz@infradead.org, viro@zeniv.linux.org.uk, valentin.schneider@arm.com, qiang.zhang@windriver.com, robdclark@chromium.org, christian@brauner.io, dietmar.eggemann@arm.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Andrii Nakryiko Subject: Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string Message-ID: <202110251407.6FD1411ECB@keescook> References: <20211025083315.4752-1-laoar.shao@gmail.com> <20211025083315.4752-2-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025083315.4752-2-laoar.shao@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 08:33:04AM +0000, Yafang Shao wrote: > Make sure the string set to task comm is always nul ternimated. typo nit: "terminated" > > Signed-off-by: Yafang Shao Reviewed-by: Kees Cook -- Kees Cook