Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp607933pxb; Mon, 25 Oct 2021 14:52:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhG5XGPLksYud8zyMl4S4lgOx3iTisR7JVVs4mDfDHTcvlkALLYsQ1mA/eNw6Tv+FGnpTc X-Received: by 2002:a63:2cf:: with SMTP id 198mr15692059pgc.274.1635198752464; Mon, 25 Oct 2021 14:52:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635198752; cv=none; d=google.com; s=arc-20160816; b=jU0irwTKgwUMxpDcmVKgqpWkoST3/ryC8C3AKtuRSp5IYiBOw3xxkLswqV/MR9rCPQ mVaoIfBllAi0dUsgfzwdwPYAfuN2XUiqEBXvKY2Rl8qsC50I219Ubz6MUyakx1jHxDbB MqYeySpJ1w8KCHZS4/Cm+VUzc39TkHeEargAa9VPLJg/EGV/96Hlb14Vi5s7mqbTd2ge Inl9qB6aCTNUM0zB87CTa9AWwEKTgoQhXI9tI4DoAeqEsJ1ZTM9W18B3QN43B9x5/jel 2X1z6he2++yA+FH6B7KBv4shH0E+2KGpvdEtY2QEshw7ODY5pOZeSYoOHC2Aed8GsuZz QSKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Zju5LQF0CqzzyZYpVZjyWcLP5n2f5gavwC3CMnwMKsE=; b=KWeV1pt4hRfhMFpmY2bVwWxcaLfPlQ7sC0nsOp1CwwIwISS/PowF+nj1Sz/wIiuu4E CTQIc3y9D0yK8bhNNPDRC4Fsygo07a6R/kRg6bnYVQrjU9w+XcaXGZRtsNQnCA1edtDm AEI9a8ibkQsrrMO6ij17MW2pmkC1E4XLGytfDykQSxxti9BKI4RtobG5ZI/MfK2uXBtH Q6ySHcaYPRZRmhoClkezU6tj2vaDTm4AWLx0XjxMfpTo8zVB3bKpTnAE6Q9iLO+QG/OH YdXj4NfYDhm7G83zJ8knzGbZ1JK5xIVW3sR0T56beesV2PVN/ukqRDLfcDGS1F+OHi9u Hm3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DnQBmEOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x3si23791757plo.430.2021.10.25.14.52.20; Mon, 25 Oct 2021 14:52:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DnQBmEOb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbhJYTJ4 (ORCPT + 99 others); Mon, 25 Oct 2021 15:09:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:60814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230201AbhJYTJw (ORCPT ); Mon, 25 Oct 2021 15:09:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C645C60E08; Mon, 25 Oct 2021 19:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635188849; bh=QkD0aIubb77MfLaXkA4RVCyqVSSVXP4CNLjP63IkeVI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DnQBmEObnLjI/kHoynHgptbLC0L02jt4LCdyS243gJXYt4vnvNZH6UY6PEbgoGTVG 5KdBh4stQvZ3HONTL7xdIip44r91p1GA6+gDA1AYLFmGXeeRmAWIckxf8z8xuw2JSi uJO2d46gy/OVFAn9XCzstEo1zMAssIl4zYYHXs58= Date: Mon, 25 Oct 2021 21:07:25 +0200 From: Greg KH To: George Kennedy Cc: tzimmermann@suse.de, sam@ravnborg.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: cirrusfb: check pixclock to avoid divide by zero Message-ID: References: <1635188490-15082-1-git-send-email-george.kennedy@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635188490-15082-1-git-send-email-george.kennedy@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 02:01:30PM -0500, George Kennedy wrote: > Do a sanity check on pixclock value before using it as a divisor. > > Syzkaller reported a divide error in cirrusfb_check_pixclock. > > divide error: 0000 [#1] SMP KASAN PTI > CPU: 0 PID: 14938 Comm: cirrusfb_test Not tainted 5.15.0-rc6 #1 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2 > RIP: 0010:cirrusfb_check_var+0x6f1/0x1260 > > Call Trace: > fb_set_var+0x398/0xf90 > do_fb_ioctl+0x4b8/0x6f0 > fb_ioctl+0xeb/0x130 > __x64_sys_ioctl+0x19d/0x220 > do_syscall_64+0x3a/0x80 > entry_SYSCALL_64_after_hwframe+0x44/0xae > > Signed-off-by: George Kennedy > --- > drivers/video/fbdev/cirrusfb.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/video/fbdev/cirrusfb.c b/drivers/video/fbdev/cirrusfb.c > index 93802ab..099ddcb 100644 > --- a/drivers/video/fbdev/cirrusfb.c > +++ b/drivers/video/fbdev/cirrusfb.c > @@ -477,6 +477,9 @@ static int cirrusfb_check_pixclock(const struct fb_var_screeninfo *var, > struct cirrusfb_info *cinfo = info->par; > unsigned maxclockidx = var->bits_per_pixel >> 3; > > + if (!var->pixclock) > + return -EINVAL; Shouldn't you be checking further up the call chain where this got set to 0? What logic allows this to be a valid value? What about all other fb drivers? thanks, greg k-h