Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857AbXABOs5 (ORCPT ); Tue, 2 Jan 2007 09:48:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755281AbXABOs5 (ORCPT ); Tue, 2 Jan 2007 09:48:57 -0500 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:52787 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754857AbXABOs4 (ORCPT ); Tue, 2 Jan 2007 09:48:56 -0500 Date: Tue, 2 Jan 2007 14:58:55 +0000 From: Alan To: Herbert Poetzl Cc: Jeff Garzik , linux-ide@vger.kernel.org, Linux Kernel ML Subject: Re: problem with pata_hpt37x ... Message-ID: <20070102145855.170c03e2@localhost.localdomain> In-Reply-To: <20070102070144.GA11270@MAIL.13thfloor.at> References: <20070102070144.GA11270@MAIL.13thfloor.at> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 40 On Tue, 2 Jan 2007 08:01:45 +0100 Herbert Poetzl wrote: > if you are interested in investigating this, please > let me know what kind of data you would like to see > and/or what kind of tests would be appreciated. I reviewed the 374 code a bit further to see what might be causing this and found the slave channel end of DMA handling was using the wrong port I think. Signed-off-by: Alan Cox --- linux.vanilla-2.6.20-rc3/drivers/ata/pata_hpt37x.c 2007-01-01 21:43:27.000000000 +0000 +++ linux-2.6.20-rc3/drivers/ata/pata_hpt37x.c 2007-01-02 14:30:18.122801920 +0000 @@ -25,7 +25,7 @@ #include #define DRV_NAME "pata_hpt37x" -#define DRV_VERSION "0.5.1" +#define DRV_VERSION "0.5.2" struct hpt_clock { u8 xfer_speed; @@ -749,7 +749,7 @@ { struct ata_port *ap = qc->ap; struct pci_dev *pdev = to_pci_dev(ap->host->dev); - int mscreg = 0x50 + 2 * ap->port_no; + int mscreg = 0x50 + 4 * ap->port_no; u8 bwsr_stat, msc_stat; pci_read_config_byte(pdev, 0x6A, &bwsr_stat); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/