Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Alexander Lobakin <alobakin@pm.me>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] ax88796c: fix fetching error stats from percpu
 containers
Date:   Mon, 25 Oct 2021 21:54:01 +0200
In-Reply-To: <20211023121148.113466-1-alobakin@pm.me> (Alexander Lobakin's
        message of "Sat, 23 Oct 2021 12:19:16 +0000")
Message-ID: <dleftj5ytkop7q.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20211023121148.113466-1-alobakin@pm.me>
        <CGME20211025195411eucas1p1f3a6830d6d0fdaac54633a0c321a55a0@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2021-10-23 sob 12:19>, when Alexander Lobakin wrote:
> rx_dropped, tx_dropped, rx_frame_errors and rx_crc_errors are being
> wrongly fetched from the target container rather than source percpu
> ones.
> No idea if that goes from the vendor driver or was brainoed during
> the refactoring, but fix it either way.

It may be the latter. Thank you for fixing.

>
> Fixes: a97c69ba4f30e ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter =
Driver")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
> ---
>  drivers/net/ethernet/asix/ax88796c_main.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>

Acked-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethe=
rnet/asix/ax88796c_main.c
> index cfc597f72e3d..91fa0499ea6a 100644
> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -672,10 +672,10 @@ static void ax88796c_get_stats64(struct net_device =
*ndev,
>  		stats->tx_packets +=3D tx_packets;
>  		stats->tx_bytes   +=3D tx_bytes;
>
> -		rx_dropped      +=3D stats->rx_dropped;
> -		tx_dropped      +=3D stats->tx_dropped;
> -		rx_frame_errors +=3D stats->rx_frame_errors;
> -		rx_crc_errors   +=3D stats->rx_crc_errors;
> +		rx_dropped      +=3D s->rx_dropped;
> +		tx_dropped      +=3D s->tx_dropped;
> +		rx_frame_errors +=3D s->rx_frame_errors;
> +		rx_crc_errors   +=3D s->rx_crc_errors;
>  	}
>
>  	stats->rx_dropped =3D rx_dropped;
> --
> 2.33.1
>
>
>
>

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmF3C1kACgkQsK4enJil
gBA8pAf/az9fjPkouZfUGTQWiQ/HrrdpDgF4NydjuJtpn7ZlJxyGgj1dPNEJZpYf
RPJe2gg55/PDBMDT6NGb/ufYaHedOs+ZuxRvXhSwc9a5n+L6mqzrZNEv0GMhT7Wq
BrTuZ6xaqHToGwfBJrJWRXV5jbK6As3N2543s9qe6N/6W3lA2vZeIwUNsdW2celT
8QgUXjEqi0y9+f6o18eLsucdRvDTTiy390aOz+MBpppHfw6fTFXceXqPoCPTEBen
v/Oh5FVJb8IYELwHELAF98Dx30rrRwDTohVoW0p7b3diC7WA61q8YKrA7mI3UqBr
K8skp3/rGQV2YTLuIta1p1ZsgW+oLw==
=ii75
-----END PGP SIGNATURE-----
--=-=-=--