Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Borislav Petkov <bp@alien8.de>,
        "Chang S. Bae" <chang.seok.bae@intel.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        dave.hansen@linux.intel.com, arjan@linux.intel.com,
        ravi.v.shankar@intel.com
Subject: Re: [PATCH 15/23] x86/fpu: Add sanity checks for XFD
In-Reply-To: <YXZmqF3KlHZBrdgn@zn.tnic>
References: <20211021225527.10184-1-chang.seok.bae@intel.com>
 <20211021225527.10184-16-chang.seok.bae@intel.com>
 <YXZmqF3KlHZBrdgn@zn.tnic>
Date:   Mon, 25 Oct 2021 22:15:03 +0200
Message-ID: <87lf2gg8u0.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Mon, Oct 25 2021 at 10:11, Borislav Petkov wrote:

> On Thu, Oct 21, 2021 at 03:55:19PM -0700, Chang S. Bae wrote:
>> @@ -217,12 +240,15 @@ static inline int xrstor_from_user_sigframe(struct xregs_state __user *buf, u64
>>   * Restore xstate from kernel space xsave area, return an error code instead of
>>   * an exception.
>>   */
>> -static inline int os_xrstor_safe(struct xregs_state *xstate, u64 mask)
>> +static inline int os_xrstor_safe(struct fpstate *fpstate, u64 mask)
>>  {
>> +	struct xregs_state *xstate = &fpstate->regs.xsave;
>>  	u32 lmask = mask;
>>  	u32 hmask = mask >> 32;
>>  	int err;
>>  
>> +	/* Must enforce XFD update here */
>> +
>
> <--- something's missing here?

That comment is replaced in the next patch which adds the actual XFD
update. I added it as a reminder. Could probably go away.

Thanks,

        tglx