Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <92c26aee-d3eb-258c-a0dd-e09783db6a20@redhat.com>
Date:   Mon, 25 Oct 2021 23:29:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: linux-next: Tree for Oct 25 (drivers/platform/x86/amd-pmc.c)
Content-Language: en-US
To:     Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        platform-driver-x86@vger.kernel.org,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
References: <20211025204921.73cb3011@canb.auug.org.au>
 <af7d7b8f-45fd-53c5-a8c4-1f594a16111e@infradead.org>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <af7d7b8f-45fd-53c5-a8c4-1f594a16111e@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 10/25/21 22:50, Randy Dunlap wrote:
> On 10/25/21 2:49 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> There seems to be something amiss with cnosole output in today's release
>> (at least on my ppc qemu boot tests).
>>
>> Changes since 20211022:
>>
> 
> on x86_64:
> 
> ../drivers/platform/x86/amd-pmc.c: In function ‘amd_pmc_verify_czn_rtc’:
> ../drivers/platform/x86/amd-pmc.c:428:30: error: ‘CONFIG_RTC_SYSTOHC_DEVICE’ undeclared (first use in this function); did you mean ‘CONFIG_RTC_HCTOSYS_DEVICE’?
>   rtc_device = rtc_class_open(CONFIG_RTC_SYSTOHC_DEVICE);
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~
>                               CONFIG_RTC_HCTOSYS_DEVICE

Hmm, yes using either CONFIG setting is a problem since it is not always
defined. Both simply default to "rtc0" though and this is also which
standard distro configs use.

Mario, can we just replace CONFIG_RTC_SYSTOHC_DEVICE with "rtc0"
here to fix this ?

Regards,

Hans