Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp927568pxb; Mon, 25 Oct 2021 22:41:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/QhEAUNfgpJLhUTyzhjNXrNVSdR3zJp7eU8ZsNg59yA7A6EGQKGvwhHDeNTJrJdp/dMvu X-Received: by 2002:a17:902:748c:b0:140:e3a:cc5c with SMTP id h12-20020a170902748c00b001400e3acc5cmr20245353pll.16.1635226901846; Mon, 25 Oct 2021 22:41:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635226901; cv=none; d=google.com; s=arc-20160816; b=o1RTFLS8Ds5VnCn+SsUxD7OwGpoFyCFU9g74rEe4dWFRGOGuwfQIYlW20/9aW4fRBr ESSYpOSsRh7wuH6HouhJv32cItm6xWuk99Lf7wv4BxaTUS8qCgWgTAaasOQLtF9TslWI ycoteo23/K4+u68uBa4+FNlsDtYfLK3iTJQ/bjYn1XX3rGf0pSSaLhfgKQO+YQUq1dA/ Y37Wsm6nL+oRwa98Sycb3ix85TuKPAvW1zCpBiJC2su4CNDWSx/JXwcwUJWrnIfOKpce EygUpZ11kdftG0r6QjKRRypSnX6l7VDNikkEeMVhqWRnMPVrYp2CI2Qnj8b27y6bezlO viZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2jLfqODImegdyXeqCFCRv0DRtHzswCpaP9EDsnOhsqE=; b=VT0WnyP27/ErTe3+0UyGExOHx6gseMnr8I6N2xPGZxZ7sHtSWhRxdHEGjAYbDseKhy Ml43I8idgZIIWqgYEw1ToRr46829iTD322/WCEyr1ZEtJ2LyrYXpZQraEYMszReAkU1+ 3VmTjbHyLOUyTW1f4AJPOZ7YrEXHOawSr0a7sqRdKRiJpyFYpG1nscsv6XdX/X1Q5QYP FbnbK5pCcNGSD0C3g78wDvmFKOQBQwx0ZKZzDZZ43t8FR9aJrw5aO+bmvzFwbCNzMJbS W5GNJXC3r54lIGYI1qqwOjwGD3MiiESt1VLpBJ0VcoLJnrxoY9S8IX9hBq5y5ZNLTLXW 9ToQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkRwmFs+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id me16si4534671pjb.74.2021.10.25.22.41.17; Mon, 25 Oct 2021 22:41:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VkRwmFs+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234463AbhJYXam (ORCPT + 99 others); Mon, 25 Oct 2021 19:30:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231394AbhJYXah (ORCPT ); Mon, 25 Oct 2021 19:30:37 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B533C061745 for ; Mon, 25 Oct 2021 16:28:14 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id j9so12955658lfu.7 for ; Mon, 25 Oct 2021 16:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2jLfqODImegdyXeqCFCRv0DRtHzswCpaP9EDsnOhsqE=; b=VkRwmFs+UC+5N5+Lua5QAFc9GjTeu4QhnyQCxzTQ97C3wCgU+kd950IiKTmkTRxnkc XSrU++KPuOTDAIT2ASvNw1clCKGSMQmhx91oENhD2wcbgbkmVCAuQQdhBt2sSI/dDTzX wJKYmTg1MIC1mGbhrn27nZt8jRxB8TC4qVgCiS6aTJXZnAEO/Wb4hRD4GGgY1F5siYq1 D93ac0jCKtPLMzH8wjP1oualVDceCiNk+A4ejfMtQH2dwu3nV8aXALkMzB9jDJT1IKzW kWZ+OZyD+80inmcrO/OAX71C25wYHf9mqp4UPLYpfOhkW9daC9EwaGY93JNZl3koj/ga xeQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2jLfqODImegdyXeqCFCRv0DRtHzswCpaP9EDsnOhsqE=; b=TzSW+9k84XBNnsPFKiOU8CBFrxjwG8qbXRNe7zTCS3/HLAPE+6rG81S04wGZfEPDSY VIePTWGyYymVgR87RcaUInqB4/fX6BozTWTOPwFv+gUqzJaewS4PBPttVFnY5dN94D3P PxVufQvAiwfuENMef0YIkS3qsEjyO/2N++d7x2OmMeHr5a8QsIwyC89ZBhDEheYRUzRP qosjazqVwX2xLCh8sJjToiOXaWuVYZ6L5ObKWLSFDyPGeX5GyBqtyxTs64Nie8OQzGPX K/8zxIZ6GpsJENEf+PoYAQRBFtwdFFBTZP3ezCaFUE5LJRp9Al1/YP9L4j50VO3mM+og 6i+w== X-Gm-Message-State: AOAM532G0QhaiKCjAO8RyaenVHzKNnMoYmJQ95sYzT8Ikc9l/VQsnu0v u+cZsXSjmP9YON2oIds1y8cLbl5nJdPfFSBbCcbi1w== X-Received: by 2002:a05:6512:3d22:: with SMTP id d34mr6400800lfv.229.1635204492715; Mon, 25 Oct 2021 16:28:12 -0700 (PDT) MIME-Version: 1.0 References: <20211025110959.27751-1-pshete@nvidia.com> In-Reply-To: <20211025110959.27751-1-pshete@nvidia.com> From: Linus Walleij Date: Tue, 26 Oct 2021 01:28:01 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: tegra: Use correct offset for pin group To: Prathamesh Shete Cc: "thierry.reding@gmail.com" , Jon Hunter , "open list:GPIO SUBSYSTEM" , linux-tegra , linux-kernel , Suresh Mangipudi , kkartik@nvidia.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 25, 2021 at 1:10 PM Prathamesh Shete wrote: > Function tegra_pinctrl_gpio_request_enable() and > tegra_pinctrl_gpio_disable_free() uses pin offset instead > of group offset, causing the driver to use wrong offset > to enable gpio. > > Add a helper function tegra_pinctrl_get_group() to parse the > pin group and determine correct offset. > > Signed-off-by: Kartik K > Signed-off-by: Prathamesh Shete Patch applied. Yours, Linus Walleij