Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp955239pxb; Mon, 25 Oct 2021 23:25:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfaX39xrwWu+HSdw+eWzirFdWZnqBkY7lBEzFRN9OqJEbOczmB9uEA6brp2SqFlPvwFKlI X-Received: by 2002:a50:fe14:: with SMTP id f20mr33473304edt.334.1635229529289; Mon, 25 Oct 2021 23:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635229529; cv=none; d=google.com; s=arc-20160816; b=Sy4VKl4PSHwDTZdjnGGRyAYUu6WmMNyMRRfEKYYvk7w14Mw8jIvFc8XjZ8GqgXVpvG N6JMub9BCs+CAgnp9csuEE7mPDyMMra3I3dlZOwZ1eaaIsmDRUS0Noki+jq+n4te+YWY AU02zQHGeWpd/gb5K8Yl1AYTx1jZdRfNL/x4TRxoeCf9WB9utNQqhuLdk6nFIsUeH/no 0TEdNXuk6c7tDF/eq3rMWwAXWnyIWzSaS0NhhIlck9v8m3016biA1pIfTR5fTacVYceP qHVi/gjTjdjYwbjDZbrUJA5/1qXCDp2HVoA97c6S6+Zg9istjKXcCdwVS+EM7t9gK2d2 ZtMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YGlkIl5tvqyYKKoyM+jpK9BICYtPqSFlKIDP3LE8ESo=; b=0qRv1aXYViKlw0HFc6mvPvO+3q3Y1mbKX/mxUhP0TBgDhMaYbwt+crD6I2KSXA6/eo 3MmxXx6A9lndt1d0l64XayT1wwaNAhRr5BxGtwjL06HaSyHkYLBgRQAxmjGmfRnaRKvp WcFi1erxBN+pBfAq9GVHlAQSBu20o4ICNk8sCZcSn9hAAPWtysdhlmGU4Dot/Oo9gT7f 7Hd01IqnNxj65oEHoJ1VILIBywjM0I7U5/YpGlLyv54PRKdzDTy6XT4Yz5JyFUS14SxC rAnOoog8mEQ6QqSfAlw78z1/EHAvBRisPN9bn9EZ7s7Q8avkV4gLSnMJ5e1STSZBy9MN 3CJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DtuK25dp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si1355296edb.117.2021.10.25.23.25.06; Mon, 25 Oct 2021 23:25:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DtuK25dp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbhJZCRA (ORCPT + 99 others); Mon, 25 Oct 2021 22:17:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:45088 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230216AbhJZCRA (ORCPT ); Mon, 25 Oct 2021 22:17:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D09861057; Tue, 26 Oct 2021 02:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635214477; bh=qIVqOavI+41kXLEr5nEtj7yZFH6f2ssL6tlpW772TII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DtuK25dpo4jA1U7aJoRVwuoO7CGt+W40QAqOjHBKSzRSAFz7bQdXojzyBOyfIuedb dbFSC9JwgWGq5XULlcWNm0qJ8K0rtQcqW+N3PalLyyftrUBlCMooss2/M/5FHjLs2k DtFOPudT7ziaa3SlV/Vk9oSINPCZbbZsVHXm1b08RQ5OG6MYGxg2W59A9tt6rlNzWL gQpeUNio4aTx2BOy/Fv6k/2ejCx+isKMZNODdMmMgL3XVW+gfVxbjEyE3n0mKWeAF5 6fR1BqvpwiQA5LV8WBa+4uN2lMogl4nXtexRququBOQ3+VIZmGePR8JpM969X0XCg7 /fs449JT4+vUQ== Date: Tue, 26 Oct 2021 05:14:34 +0300 From: Jarkko Sakkinen To: Chen Jun Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca, rui.xiang@huawei.com Subject: Re: [PATCH v2 1/1] tpm: add request_locality before write TPM_INT_ENABLE Message-ID: References: <20211013062556.116504-1-chenjun102@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013062556.116504-1-chenjun102@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 13, 2021 at 06:25:56AM +0000, Chen Jun wrote: > Locality is not appropriately requested before writing the int mask. > Add the missing boilerplate. > > Fixes: e6aef069b6e9 ("tpm_tis: convert to using locality callbacks") > Signed-off-by: Chen Jun Reviewed-by: Jarkko Sakkinen I'll queue this to v5.16-rc2 pull request (already closed for rc1). /Jarkko