Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: RrCMofBBp8IRzYHLPH/SZ0Zllk10EIPdQQc3AZ1TThPjiMqDC1QlwtloSf3cWb5EjJwSLvs/ZP
 FD9YDeinbTJ6UladwcVxwt+33kmNik0bFVk9J9poFEMEzv+5EXeLxAmAcTOVbRm7WjK2lp2onM
 fCyNJdW15EQxbo290LDfD2gg+Mb96H74kPsvRwvTq6PZ6Acj2zFl3CA0nIXaeL38UiJEqlbQYp
 47EOc2v73KtIq+XINHhIhoyn/CW0IR8HV5rz8596YBCVDNOErgOHka+HjdS/JGJVaFrV59iqa+
 ktCcSezInjMy7GQahJchc9oU
IronPort-SDR: Kbt6fj7jk2I0Kv/jAyJAdSvqipuHx8urkpow35xdKEjmx5CW+EFeQwnQDE5+e5bZxWq9w7XkEa
 80fQROPI4KnT/bQhbJT4KpQDM5ZmmEqR1VdoCjAdA14YQvF7wJF9iBmcXS2kaMjcDr0jKfMYql
 8gCfxaJ+hAvkqpdVnegJaYFQkhfWPcTJ28b+XNdiOCSEC9xRDrQxy1lG1skhK8a6AWRexPtMvS
 wb9Yh0N0Nb7j0mYSea/Wgu5xrsI0TuTB/Du1GZ6wb1wbmz4KL9dHwuhICbifd0hRlT02IQHCtR
 Q2g=
WDCIronportException: Internal
Message-ID: <81a99dd1-0ef6-9bd0-31c0-b0934023746b@opensource.wdc.com>
Date:   Tue, 26 Oct 2021 13:09:41 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] driver/ata: fix potential null pointer dereference on
 pointer last_sge
Content-Language: en-US
To:     Chengfeng Ye <cyeaa@connect.ust.hk>
Cc:     linux-kernel@vger.kernel.org
References: <20211025131304.17226-1-cyeaa@connect.ust.hk>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital
In-Reply-To: <20211025131304.17226-1-cyeaa@connect.ust.hk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/10/25 22:13, Chengfeng Ye wrote:
> The pointer cs_desc could be null if the loop is not
> executed, so there is a potential NULL-PTR dereference
> issue. Fix this by adding a null check before dereference.
> 
> Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
> ---
>  drivers/ata/sata_sil24.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
> index 06a1e27c4f84..2bd595da799f 100644
> --- a/drivers/ata/sata_sil24.c
> +++ b/drivers/ata/sata_sil24.c
> @@ -785,6 +785,8 @@ static inline void sil24_fill_sg(struct ata_queued_cmd *qc,
>  		sge++;
>  	}
>  
> +	if (!last_sge)
> +		return;
>  	last_sge->flags = cpu_to_le32(SGE_TRM);
>  }

I do not think that this fix is necessary: sil24_fill_sg() is called only if the
qc has ATA_QCFLAG_DMAMAP set (see sil24_qc_prep()) and that in turn is only set
if ata_sg_setup() sees at least one sg entry. So the loop in sil24_fill_sg()
will always be executed for qc marked with ATA_QCFLAG_DMAMAP and so last_sg
cannot be NULL.

-- 
Damien Le Moal
Western Digital Research