Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp988450pxb;
        Tue, 26 Oct 2021 00:15:49 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJz5AUj5LQZeUrFXdtrn5/CZrubN0mtpYl2o5ihnQe1qZlwBjDd/XqqISB8m6QPubpMWwTmh
X-Received: by 2002:a63:7542:: with SMTP id f2mr17577498pgn.147.1635232549323;
        Tue, 26 Oct 2021 00:15:49 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1635232549; cv=none;
        d=google.com; s=arc-20160816;
        b=zIP59ZCkk2v1/vgKuyH6Fs37p9TEUZK9fd55Tqv4NNVVHEZCocOOcxkzXNA0KBvgGv
         JNEri8L+Mhex0TmEZvq0/T9xmbnnP45ohulIvEc5nxpFm341ukEnY3Vouxhv/Us1cQqp
         p95bzGiDXWHEYLhG5ZcazAlHxul8uUoU0ncWK8Bscg2bPEJsTjvxRWo0wuDbbqdJTu/H
         S5qSx782YOwc994y5lRHoNIeYoTGLdfkOIGhE3l6MkUNVzkQ31sz5VuTTVuVd0mMVOTa
         gbpcUcuvcZp12AP87RuEE/lfi2FNLETR366YF0YaB3CSV+yp5MUo5IxKA+TDlPdK7ita
         WFGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature;
        bh=Er17uZj5lNnNB09LnO1O9fGl7hL1BW2tQkx9sB8YbfI=;
        b=w3eUwArBFPYl6sfqY0+GN5eJbIbIeLfdasiUcsMbYn36wGbU1sUVDtSai75HqxqRov
         rAIUASCI/EY6aiYy9Do+NBd6RISC8g3/t948lXZIRcaAF1g84CBa+aL62sct9vcKYyar
         87crXLTzB0euAdSXwVFcEeU+ffg0s+Ruwk/5kLa32AumtErY9A8BlwzPoip8nD4cVUbE
         JJZpsh/+ocL9mPKbp4TYCzguETUrZG/EU+pZxIS1Ra2o2xspNNr7mPgfOdm7KLqUqXMw
         bAG6gscODHqPCgLvd4PNf43Tb6lrffPkVa7rXl0fMvfSvmGX0bU1tDWVd4SugfpxyP1o
         H/KQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=eBhOJgPg;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d1si9912586plg.437.2021.10.26.00.15.36;
        Tue, 26 Oct 2021 00:15:49 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=eBhOJgPg;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233601AbhJZGCo (ORCPT <rfc822;luxiaolong211@gmail.com>
        + 99 others); Tue, 26 Oct 2021 02:02:44 -0400
Received: from smtp-out2.suse.de ([195.135.220.29]:33144 "EHLO
        smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229940AbhJZGCn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Oct 2021 02:02:43 -0400
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out2.suse.de (Postfix) with ESMTP id EBC441F770;
        Tue, 26 Oct 2021 06:00:18 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1635228018; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Er17uZj5lNnNB09LnO1O9fGl7hL1BW2tQkx9sB8YbfI=;
        b=eBhOJgPgFZ16RnwVCTAWynSDsbi3KY8eSYmnqweJO7rGubGF/34bkQ/oWOczClGmkE7T7V
        CVsviVLOz+5J73iAWHdZa6F8v3f1ikzxWudxCf4uAbaFRha30Rjdi59+TvGVTedF7g9WNV
        /u1ViH6/Udd0KnZey9abg45ss3BQqhM=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1635228018;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=Er17uZj5lNnNB09LnO1O9fGl7hL1BW2tQkx9sB8YbfI=;
        b=R8gP5i8KP5gOg2c1a9Mi1UD9gNiBTaEZRFsBkF3DStSQbsYr2Q5WJ28+sVPyAy2W4heGC5
        WNPwfwvz60PBsMCA==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 9F309A3B81;
        Tue, 26 Oct 2021 06:00:18 +0000 (UTC)
Date:   Tue, 26 Oct 2021 08:00:18 +0200
Message-ID: <s5hmtmwxr4d.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, broonie@kernel.org,
        joe@perches.com, lars@metafoo.de, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        syzbot+ace149a75a9a0a399ac7@syzkaller.appspotmail.com
Subject: Re: [PATCH next] ALSA: mixer: fix deadlock in snd_mixer_oss_set_volume
In-Reply-To: <20211024140315.16704-1-paskripkin@gmail.com>
References: <20211024140315.16704-1-paskripkin@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 24 Oct 2021 16:03:15 +0200,
Pavel Skripkin wrote:
> 
> In commit 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
> added mutex protection in snd_mixer_oss_set_volume(). Second
> mutex_lock() in same function looks like typo, fix it.
> 
> Reported-by: syzbot+ace149a75a9a0a399ac7@syzkaller.appspotmail.com
> Fixes: 411cef6adfb3 ("ALSA: mixer: oss: Fix racy access to slots")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>

Applied now, thanks!


Takashi