Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp989186pxb; Tue, 26 Oct 2021 00:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwCCfy7pa9obrIEE+eqN1JTi7/InlgfhnReqhLk7lzv+ejlHZYCA4o1RNA8+pFv4m3JWkH X-Received: by 2002:a50:934f:: with SMTP id n15mr25182974eda.391.1635232619356; Tue, 26 Oct 2021 00:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635232619; cv=none; d=google.com; s=arc-20160816; b=wju08VtSmFPVA3XbFYAJaIBfCS53sSykuay1oTRKoFVkjD/spEUBwGeACpJzgIphCS Y2ZnnB/jsQCrZQRbwEMrMw0Hhtn1JUm4vbJ9CfVNT6pow5jdXbqCcYYgEuYe5SVRxuzv mWZToe2HBXrYemu8jMj3Z0/Oku607oknFUSUI0FoBD95g34eUEGq4hASjG/3k3OMSIHN /iUVnjhas1AW/KfqU7lojdJgrEDj78HZSCYIHaUBmYIWkjFC1xCajwCIwjDEJBcPL7P8 q5LIAgte+OmWxSLNo0iICZm9v8vn5cOkkfQPV/XtaA4uF3bixWL11AXlNyyvK8OOioTC 6ysQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=gKjUTHtHr46Zc0mVSdHDGYdXrEbguNkHOoWnUzmutUs=; b=T7L4qSWmMixOW/OhJSmisyDhwORLsHbJTrOXW4flWH5DpxWppFSHMbed1fxnYL4Q5M qIpqolw9N3qCxBSBgkGAphDvoG73yM84zPA90u/FopHVCkoWBwSABK/1XBUBDGhf7N8d FzqiJ/vsywaHxt5OipYMwJTJ+Fiu3IX+Hc1lHCvYgIRaagsXxxkRX/z2kn24YSi29Pvb 5QrNgTt0dTdaKWAi/nEmhFJCl4Y99+kL7uKJiUyu8Q+d+xm5g4nO3H4ia+gKn02SV9jD ulrFWk6eWwaozOv5q55Ff29Dpk2NJgobRkXWigm+lnWOcE7YwyRZu/xCAzGCaxN39YqD 3XDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="D/qXAf7E"; dkim=neutral (no key) header.i=@suse.de header.b="/KBXeWoQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f3si8465134ejw.212.2021.10.26.00.16.35; Tue, 26 Oct 2021 00:16:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="D/qXAf7E"; dkim=neutral (no key) header.i=@suse.de header.b="/KBXeWoQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234576AbhJZGE6 (ORCPT + 99 others); Tue, 26 Oct 2021 02:04:58 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:33272 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbhJZGEz (ORCPT ); Tue, 26 Oct 2021 02:04:55 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8DD131F770; Tue, 26 Oct 2021 06:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635228151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKjUTHtHr46Zc0mVSdHDGYdXrEbguNkHOoWnUzmutUs=; b=D/qXAf7Eu7sWFSHvK/0ZeELZ9ibSQjoAvrPrPCvw1OElb2vV7eDe8N7JdwYNuFM3ic4Rpn jp3IpEKI8oGQ/FpK5nnlmblAmOx11LzdEKFtZcmUrrisqwWH9z29AR++vn2uXAjrIWRauB BTBMDYcp6BQu6QD17Jf+tQQmLLaEdKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635228151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gKjUTHtHr46Zc0mVSdHDGYdXrEbguNkHOoWnUzmutUs=; b=/KBXeWoQOOaLAVKwtgDpxwJ0dxhCEvShId6hoqwNn546nxPwB6IoEcunZMfrv1VIS3FScP aFyeHF57wZz3TtDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 7AD14A3B85; Tue, 26 Oct 2021 06:02:29 +0000 (UTC) Date: Tue, 26 Oct 2021 08:02:29 +0200 Message-ID: From: Takashi Iwai To: Chengfeng Ye Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound/isa/gus: fix null pointer dereference on pointer block In-Reply-To: <20211024104611.9919-1-cyeaa@connect.ust.hk> References: <20211024104611.9919-1-cyeaa@connect.ust.hk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 24 Oct 2021 12:46:11 +0200, Chengfeng Ye wrote: > > The pointer block return from snd_gf1_dma_next_block could be > null, so there is a potential null pointer dereference issue. > Fix this by adding a null check before dereference. > > Signed-off-by: Chengfeng Ye Thanks, applied. Takashi