Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   YE Chengfeng <cyeaa@connect.ust.hk>
To:     "agross@kernel.org" <agross@kernel.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: drivers/clk/qcom: suspected missing null check for callsite of
 clk_hw_get_parent in clk_pll_vote_enable
Thread-Topic: drivers/clk/qcom: suspected missing null check for callsite of
 clk_hw_get_parent in clk_pll_vote_enable
Thread-Index: AdfKNx9H596yrqX+T56TbsWA+cLqtA==
Date:   Tue, 26 Oct 2021 07:00:22 +0000
Message-ID: <TYCP286MB1188F60382E69E029F8C4A798A849@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sQv2ST+o6rD7wvA0DQNfYI9o9TU/prFSA4jEPkWGtNGUb1Uk9IhEy1RSRVir?=
 =?us-ascii?Q?30vJbvZ/kv0ToxbigXwr2/Hzlo+Ikn1fc5ULTsx/huVHuzvARaaFUb75RbhG?=
 =?us-ascii?Q?xuzBMrVB46fcGM9a7eRUwsL45dOpylCmuEPBwpNuaiKQE4S3EgtAoc/kirV3?=
 =?us-ascii?Q?T+pNofDIC1zoEu8HAzMuVBg9B9DwttecuqvwVANF0kA71lRQo1ltZQ7YjIml?=
 =?us-ascii?Q?rPlY8zyjXfZU8m+0JyJ00TX9o6X4t+HVKr1zhGUIIwvc04Lw/pHZD88MooSb?=
 =?us-ascii?Q?S+RfygPZb3wn2S/d7lswmwwvxnSodgMMjjQk5Ltmle22m/54bSVnTaT4/eb5?=
 =?us-ascii?Q?wFTMzbkiwkI+zFBe+1Ltp+DLV2Pa0/mS6ZeUXQmZLquEbKbYwlHPNF3HYt6P?=
 =?us-ascii?Q?2b1EYftmZoluapX8kXPHOPbDgsEufbvIP5a4acMyMdvaynV+4jO2Br7pVYNX?=
 =?us-ascii?Q?Bu/7hNHUg1C2DOKLqwPuOXe/x/FBFW9w+HdE6Cx4r9FoFByGKMzbz3whsQC3?=
 =?us-ascii?Q?6H2C6Vte8HcxpyESV2rncudIkh1krgjGZCPIEXHpRHyiMGsp7GAu1IEYvTbY?=
 =?us-ascii?Q?9DusEwYr1hE6NtS9H3H6F5AhEMfhEEiRqFFU5R5223bByt3cGVQImOtRq5hx?=
 =?us-ascii?Q?5PKO14C2eFQBoC/jhdFmObkK1blBsyNgQyEA3oo9iIr+sWJKtREShtWtuxa9?=
 =?us-ascii?Q?tXtxZgW4mH4rT44o+sxYl+WPli5RpqQmJh75uDMF4ACjpFZgGqxG3UilB+sd?=
 =?us-ascii?Q?BjFAh45OfMW81clEY594jVYWUeXVwoYFtR9ZVV1GFHIhB6c2Yaf1NMW1+YX1?=
 =?us-ascii?Q?mquwcGmXCm0jszahOG0FTJHduGpzkxPM1r2+KR0Yl4hldApJ24dwK3794r5R?=
 =?us-ascii?Q?EOlfkGSUDimd9Mc5VTptBK0dVu0u2BChgjXjrt1DdLt8KVOwvErmJvr4IJG+?=
 =?us-ascii?Q?biOUEgVkUyM49SGIsYkoTS5libI9ZYgtPi/nGOlynYA/MByRO+sZPV8iH+qN?=
 =?us-ascii?Q?4VJrEVi+gN3wlCjpp4/9+ZMce94SOe2OR/Uo3I8jGp+mybWex9QPIt9LQRIx?=
 =?us-ascii?Q?NDVzBpCu745nMSoGGzF0WW3G+q4nj2rJFU0j7vqRHwkdGHxFRuuE065k49MV?=
 =?us-ascii?Q?TsWb1kEjHz9GnwkaKp8z51hedLquajBGBqSv5swKf58FmsNy7fe7IhE9p0i4?=
 =?us-ascii?Q?3A+Ghu+i2GnnNYTZSfX8zTsxN4UQTJvav7NzS6mKe8aG3Dje6EBcNlml/yM9?=
 =?us-ascii?Q?LkMie8YCzGCmuJf0thFOLDC0kjDuGFLLLw+l6WYXaaB6adiSaIXCQ/gJbHDt?=
 =?us-ascii?Q?BbK4vudX9tWp2xiLY5Oz/g/3gR6M+6ff5FepX+6/jspNHfA9r8s6+sfzXJbM?=
 =?us-ascii?Q?KcqzBxBmBQaZxZjbttyaM6SQ9DMRBRSQ3m8yRW4mvjz+x5T+rzq2bsPqsP22?=
 =?us-ascii?Q?+I8BJBq5QZVycexUCaUugxpXxN605zLv2r3rmc7BVtHqFoNxhC28IyZ4bapG?=
 =?us-ascii?Q?keEF4I03fa4QmyKKLjVn7PSxWhRCwUODHB3Nq1LxZ3Pt5PfvaZdQ33Sk1iRp?=
 =?us-ascii?Q?GePKU9gurmg+K6V6Bn62nW4PVhidFN4615RaDDZg3VjfdkMrtYYJMdPRJqZF?=
 =?us-ascii?Q?Y1PD1R4iNx5sQPX9MkvwOvA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: connect.ust.hk
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 145de8be-c400-4ef4-2799-08d9984e478c
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 07:00:22.2156
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D/U+CwSpviUYTrZm3+Ly/gYkoBaHg3pPccSAUsmOtjDFYqnVdDFkH4gpZI7T0ehzdZJ5fOf3L8qqYIKAq1jUCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB0878
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

https://github.com/torvalds/linux/blob/master/drivers/clk/qcom/clk-pll.c#L2=
03

Our experimental static analysis tool detects a null-ptr-reference problem.=
 It could be false positive, we report this to you just in case.

In this call sites of clk_hw_get_parent, the return pointer is not null-che=
ck. We are not familiar with the code, and don't know whether it would be a=
 potential null pointer dereference problem. Would you like to spare some t=
ime to have a look at it?

Thanks so much,
Chengfeng