Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Abhyuday Godhasara <agodhasa@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Michal Simek <michals@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>,
        Manish Narani <MNARANI@xilinx.com>,
        "zou_wei@huawei.com" <zou_wei@huawei.com>,
        Sai Krishna Potthuri <lakshmis@xilinx.com>,
        Jiaying Liang <jliang@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Tejas Patel <TEJASP@xilinx.com>
Subject: RE: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
 firmware
Thread-Topic: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp
 firmware
Thread-Index: AQHXyXm2z7oJJqmDVkeNegd3tRQp3qvjY2gAgAA0UuCAAAX0AIAAAKAAgAFCANA=
Date:   Tue, 26 Oct 2021 07:19:56 +0000
Message-ID: <SJ0PR02MB859566234C2BD56F8A6D605AA1849@SJ0PR02MB8595.namprd02.prod.outlook.com>
References: <20211021134644.14407-1-abhyuday.godhasara@xilinx.com>
 <20211025082350.10881-2-abhyuday.godhasara@xilinx.com>
 <YXZsLJ3SfCjYr3gk@kroah.com>
 <SA1PR02MB8592145E6C1A9A1FA561FA33A1839@SA1PR02MB8592.namprd02.prod.outlook.com>
 <YXadDpOHWs2kUA6J@kroah.com>
 <SA1PR02MB85928833B8C133B4593882BBA1839@SA1PR02MB8592.namprd02.prod.outlook.com>
In-Reply-To: <SA1PR02MB85928833B8C133B4593882BBA1839@SA1PR02MB8592.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0ukcvGARBidunL/GpX0xPLGghoRZCJS2f+BWUb9KrQfmDGzshZBn83Uk6nbC?=
 =?us-ascii?Q?xa3Fp4wOv0Wd9qPowjzahvPohFWHjn6prgngxcIYts/ZOqvxcuSfwu2PZPUg?=
 =?us-ascii?Q?J/nUOOox3aC15QKXRqnIs6rvC80CySKmSLP4Tdg04Tzk3VbLn0UeUlMPwprs?=
 =?us-ascii?Q?X8Wi5yjzffiEvo83xXS8WDowWw+ktQdwETmyelG//5TGKm+n6v8s/ogiu6zK?=
 =?us-ascii?Q?8m8XbUEbMY+SlEXuan10OZ3TDVPichST3yQfSUnn5/Gg6eoTG361RPBkVUNf?=
 =?us-ascii?Q?aK/5oGnZU7cQcRlw5J+fnXMAb9H8WNuT+S0AwW985U0cZgHgzFxMZP/706A4?=
 =?us-ascii?Q?vOqMImOp2YfQX0oHmcsCwqRLRfPMx6WUiVpJ+g1GunZnsgPvJxJTllXCrvJl?=
 =?us-ascii?Q?uaKviC8oxai9tzZyBKQ7vWRIifzIUebW4C83cawz5UlvAl1wrOPW6Bgx3QEX?=
 =?us-ascii?Q?fV/3QmXHBJwO0QGstrqiX7Ksw7xwNJn3qwvT+8eU2CPUWv9XNncrvElFjJTm?=
 =?us-ascii?Q?Tr92Aldtx9mFMaI/osajPI151k+J41uwFriwYyZyDC8HsiFANgck0ZC5Wt6v?=
 =?us-ascii?Q?Qtdfg5Ja9HoxccJxdJzWkmy4leXE79be52fQKh0S6hqJ+g62VPUYrMvHkuJ+?=
 =?us-ascii?Q?82AzTn5buJqGroEO8D9hlTa0XXCbU/RpFjGCz3fHGEuUGzeFq6mOHouCb7I1?=
 =?us-ascii?Q?dWfPE/06gQuOybmTVIjMptqQeUzJsKrrgqKp2cQGlXICIlZBectepsT8g3dF?=
 =?us-ascii?Q?+5WyC4qpvHaM4S4UVy2XEPBKrJrXNFHZM6uZSHlvFZl+JmXWv1Ii9borusPq?=
 =?us-ascii?Q?YvgCnURcbvYYK12skZpZmigXRjPebx8Grl5WmDU/I4DttJNB+77XV/TF3Ax1?=
 =?us-ascii?Q?LcybCdbyIA3HLrnpzcIjywWLGUufPVA97BREXBkEbOBC91r+l4IQ6wGgiBHs?=
 =?us-ascii?Q?U/GZmbXbmMG9El8rHeyRy25P3LxF1i2QaY0ZDR+4oRX4wbshiOnxfGvRC+x5?=
 =?us-ascii?Q?W0JtjnD6B1t5xG0V93qFzqais5KivmFV2LNrrkiy+lyCmAI9MXbrESPRBaiG?=
 =?us-ascii?Q?ldIt99+ngMvsIWqjAx2/x1UqgH1ZM38cwrh/cVBo07g2KLX/fbM1FAgEvQXR?=
 =?us-ascii?Q?yV2+AT8R3DOylE8k6iD6lmCSUba6TW9jgDWAoimwuPvcaKs6nkkM2NF8Ym1Q?=
 =?us-ascii?Q?lAdNxOkiZ8wkkm/FyCHjm2BDG9nHOhe47blEZ6fmrFhnLDOKr10Y55Rkn4pn?=
 =?us-ascii?Q?jRObAzPsQwgpANNpqcHNBb+kZWuZgiZGXgOGCI3YSH0rY37pAfh9JTF54lk3?=
 =?us-ascii?Q?60620IE/dJsvXcTzN4G/J94EuIyEXxjPMXbwYwpdIYRMQzZUU1aSbZZ8t3At?=
 =?us-ascii?Q?UgfDHX+VtLdrh4H3uqCu+a+1+y9+QDwjh/ML5rUCbBcTzO1Nz175i38K+PR2?=
 =?us-ascii?Q?8Od0V7UocyiwqAOBSMemZh+GSQd561lp4jsuUu+7MR2ydm9pSmeRFjLqFNk2?=
 =?us-ascii?Q?AKvcLeVGd55M24rANtdZ6O1Yt+CmBIfvPpAdSmew6H3QAwQhIK/SBhPxNITi?=
 =?us-ascii?Q?LumFVODlUb2UuXEUwJr7m/2VllkJlE4wysm3pqTvq/Hejo9RaYU3bb/uJsrV?=
 =?us-ascii?Q?uFuafAVMN5kwz6XisrLrjYw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB8595.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a845623-e34b-4dd7-e15e-08d998510355
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 07:19:56.3068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zh+eudSEJaQt7CO6RSPGM4VX7pkGQzehjxq2NWOFKi0ABmMhrORwvrejeIW+ObvA1N+nuKislOgkHq63cOoW7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4390
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

> -----Original Message-----
> From: Abhyuday Godhasara
> Sent: Monday, October 25, 2021 5:42 PM
> To: 'Greg KH' <gregkh@linuxfoundation.org>
> Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>;
> Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna
> Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Tejas Patel
> <TEJASP@xilinx.com>
> Subject: RE: [PATCH v6 1/6] firmware: xilinx: add register notifier in zy=
nqmp
> firmware
>=20
> Hi Greg,
>=20
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Monday, October 25, 2021 5:33 PM
> > To: Abhyuday Godhasara <agodhasa@xilinx.com>
> > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>;
> > Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna
> > Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>;
> > linux- kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > Tejas Patel <TEJASP@xilinx.com>
> > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in
> > zynqmp firmware
> >
> > On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote:
> > > Hi Greg,
> > >
> > > > -----Original Message-----
> > > > From: Greg KH <gregkh@linuxfoundation.org>
> > > > Sent: Monday, October 25, 2021 2:05 PM
> > > > To: Abhyuday Godhasara <agodhasa@xilinx.com>
> > > > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja
> > > > <RAJANV@xilinx.com>; Manish Narani <MNARANI@xilinx.com>;
> > > > zou_wei@huawei.com; Sai Krishna Potthuri <lakshmis@xilinx.com>;
> > > > Jiaying Liang <jliang@xilinx.com>; Jiaying Liang
> > > > <jliang@xilinx.com>; linux-kernel@vger.kernel.org; linux-arm-
> > > > kernel@lists.infradead.org; Tejas Patel <TEJASP@xilinx.com>
> > > > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register
> > > > notifier in zynqmp firmware
> > > >
> > > > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote:
> > > > > In zynqmp-firmware, register notifier is not supported, add
> > > > > support of register notifier in zynqmp-firmware.
> > > > >
> > > > > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com>
> > > > > Signed-off-by: Abhyuday Godhasara
> > > > > <abhyuday.godhasara@xilinx.com>
> > > > > Acked-by: Michal Simek <michal.simek@xilinx.com>
> > > > > ---
> > > > > Changes in v6:
> > > > > - Minor fix
> > > >
> > > >
> > > > That is vague, what got "fixed" here?
> > > [Abhyuday] During rebase of patches on your tree couple of lines
> > > code was
> > get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git =
am -
> 3".
> > > I corrected the below code which was wrong in previous patch v5.
> > > +static inline int zynqmp_pm_register_notifier(const u32 node, const
> > > +u32
> > event,
> > > +					      const u32 wake, const u32 enable)
> > {
> > > +	return -ENODEV;
> > > +}
> > >
> > > In v5 it was like below, which is wrong static inline int
> > > zynqmp_pm_load_pdi(const u32 src, const u64 address) static inline
> > > int zynqmp_pm_register_notifier(const u32 node, const u32 event,
> > > 					      const u32 wake, const u32 enable)
> > {
> > > 	return -ENODEV;
> > > }
> > > So, the body was missing here for zynqmp_pm_load_pdi in v5.
> >
> > And why did you not describe this in the changelog text?  That is what
> > I was asking about here.  Please be specific, as reviewers need to
> > know this type of thing.
> [Abhyuday] Just to avoid longer change log I added it as "Minor fix" this=
 time,
> but will be taken care this type of things from next time.
> Are you expecting the v7 for this time ?
[Abhyuday] Submitted v7 with updated cover latter and version history as pe=
r suggestion.


Thanks,
Abhyuday

>=20
> Thanks,
> Abhyuday
>=20
> >
> > thanks,
> >
> > greg k-h