Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 Oct 2021 21:08:43 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 04/20] trace/osnoise: Use
 start/stop_per_cpu_kthreads() on osnoise_cpus_write()
Message-ID: <20211025210843.36fe2829@rorschach.local.home>
In-Reply-To: <2b4ea45b1802844cffd98b6a208b22bc4664c795.1635181938.git.bristot@kernel.org>
References: <cover.1635181938.git.bristot@kernel.org>
        <2b4ea45b1802844cffd98b6a208b22bc4664c795.1635181938.git.bristot@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 25 Oct 2021 19:40:29 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:

> When writing a new CPU mask via osnoise/cpus, if the tracer is running,
> the workload is restarted to follow the new cpumask. The restart is
> currently done using osnoise_workload_start/stop(), which disables the
> workload *and* the instrumentation. However, disabling the
> instrumentation is not necessary.
> 
> Calling start/stop_per_cpu_kthreads() is enough to apply the new
> osnoise/cpus config.
> 
> No functional change.

I nuked the "No functional change.". You can't have the changes of the
above and say there wasn't functional changes, as the first paragraph
explains the functional changes.

-- Steve