Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1040474pxb; Tue, 26 Oct 2021 01:33:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZJI2+vvnpXm8jEiyo1DWl2oUnHLU3xqc2PKTgcvDRZuBsAiRkjcf/33mTQxQ8moZcEkfm X-Received: by 2002:a17:90a:4bcc:: with SMTP id u12mr3610564pjl.180.1635237212605; Tue, 26 Oct 2021 01:33:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635237212; cv=none; d=google.com; s=arc-20160816; b=kVqil/bY+bL23kb9zq3Gk2PWGLK0nHA2Wnuc1npw7HItkORTI8QYYfWq7TobTPuUS5 VNksBM4t1c2U/2O0Fe1qu9/lIOI7Jwh3xfnE9f5TbkNi3UW/IYDQp9Jz/cFYW432+dIZ 11beCoN3J4kmzvPLyWe+IoMH6tAJczkudBluoH1RyTsrhX0BIYkAJzVUkAEJAmQ6TP8S 9N2wB/NoWKomI2pDHCMIvBOOzNnCSSmfzdu+CTP+2O1YNvhHB1QVWwHMvs5ivSOKEQxu 5paUw7FP5vFD3Y8+Mmbc7hGvN/Zp+d1ypXq/qqe5W2fGu+b9tg0Hr/5XmRRBpwZYmyl1 AKeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=cnWuWjh4H1UhOaUxI2972kvo6MATwr45G4u1Pjq/WSo=; b=MyJ56pIy7ePe7B3l6DUcPvtYXIK08aCo3Ea1ju7XzUI2m+XQ1TM6JnDdUoZmB12h0F jDuErdWNkCqIXg04gcq2XNjJ+LM4axwwi0uDdRmp09J3LXclPpMTWfu4vjOfGO+789Ii 1pJvPecZPGQ1g2tZ95E7E0fxbskPPdlaUs0+bGvogedXUZP4c+aOhkO4Qt6sH7sfg6iK ro0mOqPkMe0TIPCqZAOJNPDGp+Jb7idDH6nR9eoJq46VJe9YxDXBu9fSZEjQRhkAixls k8ZK3WJz3rB//ERTLqo5B/c4oj2pKHtsV8xq15pLBvec2UfsDbA7jSkxlvctsiry4PAt n7MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SyND6e5b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g3si17092610pju.119.2021.10.26.01.33.18; Tue, 26 Oct 2021 01:33:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=SyND6e5b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234381AbhJZDZe (ORCPT + 99 others); Mon, 25 Oct 2021 23:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231469AbhJZDZd (ORCPT ); Mon, 25 Oct 2021 23:25:33 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66612C061745; Mon, 25 Oct 2021 20:23:10 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id k2-20020a17090ac50200b001a218b956aaso549237pjt.2; Mon, 25 Oct 2021 20:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=cnWuWjh4H1UhOaUxI2972kvo6MATwr45G4u1Pjq/WSo=; b=SyND6e5bMhlPf6FlcwC+gAg7JqoOy6a4sUKXTLo0KpPNyWN9QEBP9APKv72NZu+GTz b+HWcripM2Vjz0maJpyG1A5bv/b1yWXixC726M0EYpjh13u7ASNp2aSX0cE7zqzBgY73 xDYfZrGYOCukJxTmtprrC26kyjG6sIN6iFhwXasTKM/fTwJZINcDnjBNRkVcu1Jqx3DB oi0AWD8CpGK+g8zKADp+kNWeALXBq54ruJLbbFpbC1YJ/rKgAzrTdT2SOypD7ap+s1s6 XjIW1ETQwZnSQQpRL6xJbtBspq6yGmRqvuTnD5Gmz6G0nujBjB1jKIYfyFpTl8ZpcTvC sc6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cnWuWjh4H1UhOaUxI2972kvo6MATwr45G4u1Pjq/WSo=; b=K56VgARottZeNiAo8sqcBUlfxqmNtyNcrLpMAL28XIewC7FFor/6dWQ6gJmGpf/qck d2y0g8gUSCNuB3LSVwT5G4IPVadqxjQmubllRCFvzYk490QoU2z6P/6QaP6brOD+Nkg8 dwrzUDl8yc1bpPZPnljPBzBgQUlh0ABgOWaU9axlUhlZFWs+yeV8mLe55NNcMKyk5PK/ 0OW6OWtnwDeB5Xa9062zgJE1d4Fgjz6Buvj0327RhY6DmX0+yEc3+n8vnRmHkYzhwFY3 5vutkskpEVIFaX2GXHjUvM2icip1WgX08p/k3CFN0YF0TGMRsYEh2uQ+F2fF3w43RtnQ MVlQ== X-Gm-Message-State: AOAM533FgEqNSaV7aQuJkkJV6WwTM22KvELqtPDeh0fbalDP7lFYai2b ArWTyqxVNw3yga+4pVyUl54= X-Received: by 2002:a17:902:d885:b0:13f:c50f:9ac with SMTP id b5-20020a170902d88500b0013fc50f09acmr19669265plz.53.1635218589890; Mon, 25 Oct 2021 20:23:09 -0700 (PDT) Received: from BJ-zhangqiang.qcraft.lan ([137.59.101.13]) by smtp.gmail.com with ESMTPSA id j16sm618777pfj.16.2021.10.25.20.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 20:23:09 -0700 (PDT) From: Zqiang To: axboe@kernel.dk, asml.silence@gmail.com, io-uring@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Zqiang Subject: [PATCH] io-wq: Remove unnecessary rcu_read_lock/unlock() in raw spinlock critical section Date: Tue, 26 Oct 2021 11:23:04 +0800 Message-Id: <20211026032304.30323-1-qiang.zhang1211@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Due to raw_spin_lock/unlock() contains preempt_disable/enable() action, already regarded as RCU critical region, so remove unnecessary rcu_read_lock/unlock(). Signed-off-by: Zqiang --- fs/io-wq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/io-wq.c b/fs/io-wq.c index cd88602e2e81..401be005d089 100644 --- a/fs/io-wq.c +++ b/fs/io-wq.c @@ -855,9 +855,7 @@ static void io_wqe_enqueue(struct io_wqe *wqe, struct io_wq_work *work) io_wqe_insert_work(wqe, work); clear_bit(IO_ACCT_STALLED_BIT, &acct->flags); - rcu_read_lock(); do_create = !io_wqe_activate_free_worker(wqe, acct); - rcu_read_unlock(); raw_spin_unlock(&wqe->lock); -- 2.17.1