Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ASoC: tegra: Add master volume/mute control support
To:     Jaroslav Kysela <perex@perex.cz>, broonie@kernel.org,
        lgirdwood@gmail.com, tiwai@suse.com
Cc:     jonathanh@nvidia.com, thierry.reding@gmail.com,
        alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1635159976-17355-1-git-send-email-spujar@nvidia.com>
 <79541c76-2c2b-fd4b-60c8-67ee6b8ea3fa@perex.cz>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <8cb777f9-b73b-136c-f560-de4c31af931e@nvidia.com>
Date:   Tue, 26 Oct 2021 11:53:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <79541c76-2c2b-fd4b-60c8-67ee6b8ea3fa@perex.cz>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SERlZHJnMHB5NkxndmZLY2l3SU9tM0xZeFljZG00Y3VHdjQ0VHhUZjBEOWQy?=
 =?utf-8?B?cSthZFhYZXdQMk1uaTkwbzJoRXkyeTJrVklUL1RyclhhK0ZlZ1M4VXVOVmpX?=
 =?utf-8?B?M0dqQWxxM1FTWU8vcjU0OWc0UDVmME43MExYeG5KdWNUTzZ4SUxNYW1YQXVy?=
 =?utf-8?B?d05Pa05DM3lhcXJKa1Y0WnFqWHhiUGlBeEwwdHZMazZTUld0V0FpNzc3OUI3?=
 =?utf-8?B?VENtZXVRM1g2ZnJvSUdjTlk4L0RzTjFGaG1hSzNHSHd2Y1p4M2pVRHRlUHBC?=
 =?utf-8?B?NW9IRmtnTXNjNGhLZ1Z6ZUFUR3MxMzhIc2hMMFo0U1ZmYmpVSVo4ZktaUUJK?=
 =?utf-8?B?cTJQY2RaNW9Fazl6dmtUNDdYZXdnL2JSUjNjWThwNVJQdkhqN3RnT2lNZ0Zs?=
 =?utf-8?B?cnIxUkF1blNYMU9SUzV6enB6MmY3VDdaQlJBSnVHam9pdnJxQmp1NWJXL0pS?=
 =?utf-8?B?c2JJZkIrV0NPc29BN0lsYzNOZlJVS0YyT0VDRnNUZFkyUzhzWk5YckI5VFVk?=
 =?utf-8?B?UUViVVNZajdxMzhJZzRZVEJocVBWN0VEMk5UOWtKSDdSdHp3amcwTHZCWUhl?=
 =?utf-8?B?WGRjSFM2Mk93RlBhaTdPQ0FxeFlUM2EzWkNFcTM2dmVVV08zcUgzRi85RHpy?=
 =?utf-8?B?OC9XckhmaWcyQTZtMlFMTnpDeEVTSFhJaXpRSjl0aEN2M2owTEJlWWJjZGNC?=
 =?utf-8?B?WmM1cVhFVHNkTEI2SnNHd0RpR2xPYVdHOGk1SlVaTmxxV21qaWpsZjNnbTVE?=
 =?utf-8?B?aWJTWElldFNBcVMyd083b04yYW44RWIxMnlLU3RVcDhob2dvaG1ZWDVsNGVa?=
 =?utf-8?B?cHN0eDZaRmdJM1NnVldsbmgzRzhTMU1kRUcrd1daNXB3WjhHMlFyTmdEWGhB?=
 =?utf-8?B?WUpqYXE0ejZIT242dEFjZy8zTWJFZklrQUJuelZZL2FNRVgwaHVmUVhGZXRJ?=
 =?utf-8?B?THNwMWFaSEE4ZHZXR0pZcjFtNDhZTWpXVEVLV05oRXowcGxtYUx4L21XUkhk?=
 =?utf-8?B?a1dIYkRKVkppR3QxTVlBRUdtdDNNZzcyWldEdncwUnFicVNZWWh3MmdzcHBy?=
 =?utf-8?B?SjdyeG04OTlUcmd0Y09FcWpOTlFNMHl5VHMrUzhkWW5MVHdTOXlXSFZ6K2Ry?=
 =?utf-8?B?MlN5UkV1TXYzM2pkYjM0amlCSVIvRGFhdDJ4UWNXSXJSQ0ozbWdSQjBKbE9M?=
 =?utf-8?B?djAwSVY0K1h1c1hBekNDUkNYR2dHc1Njd2hWWUhNTmVCNzlKbUVoN095d1Fh?=
 =?utf-8?B?cXArYWI0bFdMMklaODdMV1haN093VHNUK3dtOFcrR0M4ZGhITEkwZEpNZHJP?=
 =?utf-8?B?QXpndzMzU2xMTVowZTZPemQ5bXRveW85ekgxRFJxampPR285TnhDNTZxeWow?=
 =?utf-8?B?T0JRSDh4NG85UmUrWlU3cytEZW5jRlVhb0l1MUEyYmMwcE5qN1lFK1gxR1lx?=
 =?utf-8?B?OG9BRmNRd0srd01ZM2trRU1GNTRzTDFHaUF0bFpRMnkvaUlFU2U3VGRHUXNT?=
 =?utf-8?B?bGxJSFMwaW9jVkRNZVY5ZGlSRnUrUVZOamtUVDcxZjVwNWRPS1JUcFBxbW9j?=
 =?utf-8?B?MGlrdmY3SExtWnA0MnZBY2hKNU9Gbm5DbGNRcitwaW1vcmkzM05LOXE5MHRG?=
 =?utf-8?B?b3JoR2JTLzZuajR3Z0lVWTJYV1RLNGNYd0ZpUWZtblhEVnZoRjRMN0FlYTlY?=
 =?utf-8?B?ZTJZcVd1SWEwQzRvRHZKRXJMUEc4aEdjUTR1dzlzMUpZK0I2eUNCN2kvVnhW?=
 =?utf-8?B?NGNSM29NWEpBaEtFTnA4ZUxwK21xNmFKS3dRZVlvZjF3cWNsemJ6cXFBTGto?=
 =?utf-8?B?TytERHBWME1UTElaVGpEU0w2VzZ3Zk0wRzRYTDZoejhHalliMUNkYjREV3hm?=
 =?utf-8?B?cmM2dnBpWG1vemMvN20rNVp3Yi9MdWlSS3NTTGNVM0xSTFA1TXlCU3ZqUTB3?=
 =?utf-8?B?bStCN3h2MDJnb0cvdS9kYkxaQzhicHJhU2FoaXFTNUFEcGJ1Z2lTNFhpK0RP?=
 =?utf-8?B?OFo1dnRoWmtIc1RNdWlXL255RjFBM3JiamE3ckRBM3QwU20xT1JSalNwczky?=
 =?utf-8?B?dnVSbFlDMzB0RTdWTDFUY1F3NkNTdzR6MVM2RExZUDhJczZpRUVVaFMyNXNt?=
 =?utf-8?B?TkhuTk5FMkhCVlZrZVpTNzB3aXRaNTZRUlBMUmIySXpHTlJRK01iaFRINnBo?=
 =?utf-8?Q?RC9hvnrAf+cxo6hF0zg0OFE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 639fcfb4-1a29-4b46-5736-08d9984927d4
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5324.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 06:23:41.9182
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ghp/4GudO3G25Enw1gLZr7U4dIor+VBtQzIOj7dl0UnZ8km/amQk1L7sNqUxXdHBDwilkBPK3JpQoGa0SzFTfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5368
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:
> On 25. 10. 21 13:06, Sameer Pujar wrote:
>
>> @@ -150,11 +186,22 @@ static int tegra210_mvc_put_mute(struct 
>> snd_kcontrol *kcontrol,
>
> ...
>>
>>       return 1;
>
> It's a bit unrelated comment to this change, but it may be worth to 
> verify all
> kcontrol put callbacks in the tegra code. Ensure that value 1 is 
> returned only
> when something was really changed in hardware.
>
> The tegra210_i2s_put_control() has opposite problem for example - returns
> always 0 which means that the change notifications are not send to 
> subscribed
> applications.
>

Thanks Jaroslav for review. I will keep a note to review put() calls in 
Tegra drivers and send fixes accordingly.