Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 03/21] perf pmu: Make pmu_sys_event_tables const.
To:     Ian Rogers <irogers@google.com>, Andi Kleen <ak@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Jin Yao <yao.jin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        John Garry <john.garry@huawei.com>,
        "Paul A . Clarke" <pc@us.ibm.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Riccardo Mancini <rickyman7@gmail.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Kees Cook <keescook@chromium.org>,
        Sami Tolvanen <samitolvanen@google.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Zhen Lei <thunder.leizhen@huawei.com>,
        ToastC <mrtoastcheng@gmail.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Felix Fietkau <nbd@nbd.name>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Song Liu <songliubraving@fb.com>, Fabian Hemmer <copy@copy.sh>,
        Alexander Antonov <alexander.antonov@linux.intel.com>,
        Nicholas Fraser <nfraser@codeweavers.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Denys Zagorui <dzagorui@cisco.com>,
        Wan Jiabing <wanjiabing@vivo.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Sumanth Korikkar <sumanthk@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Changbin Du <changbin.du@intel.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        Andrew Kilroy <andrew.kilroy@arm.com>
Cc:     Stephane Eranian <eranian@google.com>
References: <20211015172132.1162559-1-irogers@google.com>
 <20211015172132.1162559-4-irogers@google.com>
From:   kajoljain <kjain@linux.ibm.com>
Message-ID: <ec94273e-2f11-cee9-4d8d-4cc9d664c0b2@linux.ibm.com>
Date:   Tue, 26 Oct 2021 10:56:00 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211015172132.1162559-4-irogers@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/15/21 10:51 PM, Ian Rogers wrote:
> Make lookup nature of data structures clearer through their type.
> 
> Acked-by: Andi Kleen <ak@linux.intel.com>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/pmu-events/jevents.c    | 2 +-
>  tools/perf/pmu-events/pmu-events.h | 2 +-
>  tools/perf/tests/pmu-events.c      | 2 +-
>  tools/perf/util/pmu.c              | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Patch looks good to me.

Reviewed-by: Kajol Jain<kjain@linux.ibm.com>

Thanks,
Kajol Jain

> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 5624a37d6f93..a31de0f77097 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -832,7 +832,7 @@ static void print_mapping_test_table(FILE *outfp)
>  
>  static void print_system_event_mapping_table_prefix(FILE *outfp)
>  {
> -	fprintf(outfp, "\nstruct pmu_sys_events pmu_sys_event_tables[] = {");
> +	fprintf(outfp, "\nconst struct pmu_sys_events pmu_sys_event_tables[] = {");
>  }
>  
>  static void print_system_event_mapping_table_suffix(FILE *outfp)
> diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
> index 42c6db6bedec..f6c9c9fc4ab2 100644
> --- a/tools/perf/pmu-events/pmu-events.h
> +++ b/tools/perf/pmu-events/pmu-events.h
> @@ -54,6 +54,6 @@ struct pmu_sys_events {
>   * table of PMU events.
>   */
>  extern const struct pmu_events_map pmu_events_map[];
> -extern struct pmu_sys_events pmu_sys_event_tables[];
> +extern const struct pmu_sys_events pmu_sys_event_tables[];
>  
>  #endif
> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c
> index 8a1fdcd072f5..c0f8b61871c8 100644
> --- a/tools/perf/tests/pmu-events.c
> +++ b/tools/perf/tests/pmu-events.c
> @@ -258,7 +258,7 @@ static const struct pmu_events_map *__test_pmu_get_events_map(void)
>  
>  static struct pmu_event *__test_pmu_get_sys_events_table(void)
>  {
> -	struct pmu_sys_events *tables = &pmu_sys_event_tables[0];
> +	const struct pmu_sys_events *tables = &pmu_sys_event_tables[0];
>  
>  	for ( ; tables->name; tables++) {
>  		if (!strcmp("pme_test_soc_sys", tables->name))
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 4bcdc595ce5e..c04a89cc7cef 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -873,7 +873,7 @@ void pmu_for_each_sys_event(pmu_sys_event_iter_fn fn, void *data)
>  	int i = 0;
>  
>  	while (1) {
> -		struct pmu_sys_events *event_table;
> +		const struct pmu_sys_events *event_table;
>  		int j = 0;
>  
>  		event_table = &pmu_sys_event_tables[i++];
>