Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 10:52:21 +0200
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 3/7] PCI: imx6: Fix the regulator dump when link never
 came up
Message-ID: <20211026085221.GA87230@francesco-nb.int.toradex.com>
References: <1634886750-13861-1-git-send-email-hongxing.zhu@nxp.com>
 <1634886750-13861-4-git-send-email-hongxing.zhu@nxp.com>
 <20211025111312.GA31419@francesco-nb.int.toradex.com>
 <YXaTxDJjhpcj5XBV@sirena.org.uk>
 <AS8PR04MB8676A0F3DA3248C6A27801148C849@AS8PR04MB8676.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS8PR04MB8676A0F3DA3248C6A27801148C849@AS8PR04MB8676.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EZw2rhPHtSEvTvdiBQtCst/AvAnNMPM+QQPsAltlz1JBc0SlnMNYNFhZmacF?=
 =?us-ascii?Q?w2kh4jT1kek2EOQ8RfLpyf0/VfYx24TsPQJEN/bK0GKFooZWFzTxeGjDw8QN?=
 =?us-ascii?Q?1kgTx2DX2RoZ3Zitt9xjQfyN3diaAPMQMuOhzxd+Sb39dUvz+BSt2Kx9nwbS?=
 =?us-ascii?Q?WVPr2vaXejsqWbw9vROndhC4g+eyF64/MxZgjjNvrirHjRht2qG863kX+zUa?=
 =?us-ascii?Q?LOQd1awtHWN/2bWPMXU/lyoKQ7BUn4eBesN58rQvzDyzJIx2xJgijnB7C6tJ?=
 =?us-ascii?Q?QBnbbxOaTYY6ywAJNIYBEh/iaRrsS9NIcKkMlg/E1x2WH1yE93elmsDRpwO9?=
 =?us-ascii?Q?oaSeTLx2zLWCbCKEYWoi6SZacSNLaDFw9baOcI5moPMTDRrPqYRJ/qp/nUps?=
 =?us-ascii?Q?gsRSBjptcLTrJfQVwlffTu2aefK7cz7fxB/J3ilbB+eabD6x5sBF7w79uuep?=
 =?us-ascii?Q?lrGdYj5EQiOdfzU2AddR1fMuUzQ2pohsmzx7i2+yEBDOuTCgwPDHCpnbnpAS?=
 =?us-ascii?Q?Gab/saeL7NKhX+J2xOkpqHwqr2vkPIh+rjBCVOqP85+UyuEy+0Mt+oTHTPrh?=
 =?us-ascii?Q?quYy05Rd/jS2uBKMNF2xw79Ut++wvqkKJ7ZoZXYSsyN4ZV02EnfeByjjKF9U?=
 =?us-ascii?Q?/fiQ2vscVGzPQf0FRIh0o1VV9BmmgrumuwYdhFPkfykGlRx++ksb3WIpdzGB?=
 =?us-ascii?Q?LwN6UeWeSGcbW1sfXCaGYp2Ikjo5e3D/MHcXZf0cFEjNHMGaGjqTy/oKRUo3?=
 =?us-ascii?Q?/TwJV830jRiqkd+2/IBhi1uUa+quP6MZkRlxlqmwu6YFd7/C5alVxbVNCJ4A?=
 =?us-ascii?Q?FyIy78vY8v7Oy4s7/V1l3tm3kFs/AEVf+hZFyxG4GEQhuZ8rNUOKyx1qTVo3?=
 =?us-ascii?Q?9qv4WG3HNHJ3PSyBKwu5bFiLjOdPVpX5KaePHIgeJ7HHm+ishevgP5FzJfwa?=
 =?us-ascii?Q?u9wEPlaeq3tPIZ8SgJ9KJfPHJrt9bWxLX5ZKkJidBLe35kDx6Mw6XyIv8qqI?=
 =?us-ascii?Q?amUKkh/a0RMuBBbpK/LVOfJL5mMLVkapKylBH/28+9PhUHDbjwF371i1V8cr?=
 =?us-ascii?Q?Qjsj+SfYISlsr65myEOYRCyQBc47JXDeD0KdQvPCp0C7EGICNnbXvryTvFGe?=
 =?us-ascii?Q?ZN9OmLIpz5SVX4zifPZMcF6VQZ4N+y/EtexoceRL+uiWNDuj6gyPJlp1hhNP?=
 =?us-ascii?Q?UZdP37ILERIWL1A0wUwDSYiLVW7p5hC2HLrizBX3KvVbcrXp/9HF1m9b25av?=
 =?us-ascii?Q?vowq3SCYxZkC49yYx5mIMTeF2OR4fZedYul7HnzCPydj+kLJXTJf0f4awCm8?=
 =?us-ascii?Q?6xE+UwQRT13ASLC7YpfpyZYUL/EBBgL8JyRqsq0214dhetg8FE59eryf0v5z?=
 =?us-ascii?Q?5oLkr6RTXpTR2dXWnc/MUElYFPdOs/HLsjvxgKhAo081eJzg7ZkwiBGPP4/V?=
 =?us-ascii?Q?u4rc46D7vMWwKm3GHwI7803Rda2eFy4040KKBeqPM3QZHMkjbUgRt5yhooM0?=
 =?us-ascii?Q?FFStLwC+aczD+EROi1fS8pG4qiHTcTn8pH652BiIxjBBRTXYYcetHniR8VjA?=
 =?us-ascii?Q?lFjLl8g3BJUpFW6CKZYfjw8PrT5yNSelh6XpPLNgT6L9R7NWBzr10rh1mNjS?=
 =?us-ascii?Q?kYCpb97AjTc0g5s6NltaHig4M+Jg21lQykv5+BW4X5hLt48bsp3vsk25AQFG?=
 =?us-ascii?Q?W68WCR2CwIZ+Hzrk48dZAqwvOV0=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec9b0aad-dce0-49b9-e758-08d9985dece1
X-MS-Exchange-CrossTenant-AuthSource: DBAPR05MB7445.eurprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 08:52:22.4578
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iW1GRISOX0BBZfJKsC95DK0hhVRpjZXOhJ9T76ILxs7wFdE/EoUV5lrQzTGelGpKX7JdYVYVrASC1Hcz684VWGEaET0SWBkk+EMzERiBmGs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR05MB8298
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 26, 2021 at 02:18:18AM +0000, Richard Zhu wrote:
> The _enabled check is used because that this regulator is optional in the HW design.
> To make the codes clean and aligned on different HW boards, the _enabled check is added.
> 
> The root cause is that the error return is not handled properly by the controller driver.
> I.MX PCIe controller doesn't support the Hot-Plug, and it would return -110 error
> when PCIe link never came up. Thus, the _probe would be failed in the end.
> The clocks/regulator usage balance should be considered by i.MX PCIe controller, that's all.
> It's not a general case, and the problem is not caused by the regulator support.

Hello Richard,
I have one curiosity on this topic. Does this works well in case the regulator
is shared? I just want to be sure that if the regulator is shared everything is working fine
even if the PCI-E link is not used or not coming up for any reason.

Francesco