Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Colin King (gmail)" <colin.i.king@googlemail.com>
Message-ID: <0ed0b3bd-05ab-d357-56a3-e2ce33169030@gmail.com>
Date:   Tue, 26 Oct 2021 10:34:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH][next] gve: Fix spelling mistake "droping" -> "dropping"
Content-Language: en-US
To:     Denis Kirjanov <dkirjanov@suse.de>,
        Colin Ian King <colin.i.king@googlemail.com>,
        Jeroen de Borst <jeroendb@google.com>,
        Catherine Sullivan <csully@google.com>,
        David Awogbemila <awogbemila@google.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211026092239.208781-1-colin.i.king@gmail.com>
 <a7155c22-c487-9a76-d3b3-628c0e27d3b0@suse.de>
In-Reply-To: <a7155c22-c487-9a76-d3b3-628c0e27d3b0@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26/10/2021 10:32, Denis Kirjanov wrote:
> 
> 
> 10/26/21 12:22 PM, Colin Ian King пишет:
>> There is a spelling mistake in a netdev_warn message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> 
> you could fix the second instance as well:

Will do. Thanks for noting that :-)

> 
> grep -nri droping drivers/net/
> drivers/net/wireless/mac80211_hwsim.c:1279:        /* Droping until 
> WARN_QUEUE level */
> drivers/net/ethernet/google/gve/gve_rx.c:441:                    "RX 
> fragment error: packet_buffer_size=%d, frag_size=%d, droping packet.",
> 
> 
>> ---
>>   drivers/net/ethernet/google/gve/gve_rx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/google/gve/gve_rx.c 
>> b/drivers/net/ethernet/google/gve/gve_rx.c
>> index c8500babbd1d..ef4aa6487c55 100644
>> --- a/drivers/net/ethernet/google/gve/gve_rx.c
>> +++ b/drivers/net/ethernet/google/gve/gve_rx.c
>> @@ -438,7 +438,7 @@ static bool gve_rx_ctx_init(struct gve_rx_ctx 
>> *ctx, struct gve_rx_ring *rx)
>>           if (frag_size > rx->packet_buffer_size) {
>>               packet_size_error = true;
>>               netdev_warn(priv->dev,
>> -                    "RX fragment error: packet_buffer_size=%d, 
>> frag_size=%d, droping packet.",
>> +                    "RX fragment error: packet_buffer_size=%d, 
>> frag_size=%d, dropping packet.",
>>                       rx->packet_buffer_size, be16_to_cpu(desc->len));
>>           }
>>           page_info = &rx->data.page_info[idx];
>>