Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Rakesh Babu Saladi <rsaladi2@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXT] Re: [net-next PATCH 1/3] octeontx2-af: debugfs: Minor
 changes.
Thread-Topic: [EXT] Re: [net-next PATCH 1/3] octeontx2-af: debugfs: Minor
 changes.
Thread-Index: AQHXydSgFT9IM4AXDk6m4Hnsb+1i16vkeX8AgACOLMA=
Date:   Tue, 26 Oct 2021 09:44:18 +0000
Message-ID: <CY4PR1801MB18800DDB8461FA1B5F53DD828A849@CY4PR1801MB1880.namprd18.prod.outlook.com>
References: <20211025191442.10084-1-rsaladi2@marvell.com>
        <20211025191442.10084-2-rsaladi2@marvell.com>
 <20211025181244.13acd58b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211025181244.13acd58b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bCwnijBK3g43o3UmX/Jl+TotZXZkYrtww0yxbhfCvujjFVjN78F12Y4hEjtT?=
 =?us-ascii?Q?hXMWgHPM25nLdCQsE6dy9M46qxSykTuE07AuC0knVwskwSu2XMyMxThU7LMn?=
 =?us-ascii?Q?85K4Ms1eB9V3vmQATCzJKw6H4x1ivaWdbvJrQ8PEuFXDkAt8JhOmE2EJLMA0?=
 =?us-ascii?Q?jU1ldDhYGv1YHzGBH2VyEptEtYHDROiADOnc91dDM7ND4yFqM1rRGEUjYfYG?=
 =?us-ascii?Q?ujfcDmamRHKzDRQ6bTWMoBxcJqoQMFJdVLgdTesu85l9jyjxQ8WJgh7eSrQ7?=
 =?us-ascii?Q?uzTof6A1r/VuaUMmMKYIFp20S2svwsY01QEYNtJi0mmednM35L+lii4elRKg?=
 =?us-ascii?Q?5WcVeKJh2QN3/GO+zZuUcON9/qhEqRxrY57Yu52nKVgi8Cma+pcH8dHA1lZE?=
 =?us-ascii?Q?mH+vc33jwR8kmmvsyWN63YaGY8+dxS7zU8RnXggQzeWPSf7P+T0SlTi0br7R?=
 =?us-ascii?Q?EnlbvEHNcxnmjx/0B9PA0z/iRqmmUaCk71/dAhJSk6cHfAC1V3s6uI6BFIRU?=
 =?us-ascii?Q?+GBpQD796JSzZz2e+cF0T2r84vmIBLwvm5JArRS/f3c9xxwheBQsV3RNgPU5?=
 =?us-ascii?Q?AdSv7b0YY5d+msDwWIpMWUZsh4bXa+gJWAUiCI9Ez9i5ez3BURKhsD4xr2g+?=
 =?us-ascii?Q?sg0dL9m99lAfpQQqV6xspjt09w6UqZ9O3I68q5Qcs5ZtK+2hB9AjInhj96Dn?=
 =?us-ascii?Q?BK4WzG5LntWWX+Ji1u+T9Zoh8ReUV27c6Hgg1qOKVmqF5WMsA7TZIc1DWiqM?=
 =?us-ascii?Q?3x8ji35c2kk5CVCiWvNQD/vOeCSeOBghqMePW9dkLXA/AC7r3GzNEAsYmCz7?=
 =?us-ascii?Q?GjHqoc7LfaJzMgSAnonhYgU/6fRamfMJDnQqBmjPHmQBG1uDDQeYC5qYx2Ok?=
 =?us-ascii?Q?GvnrfxLynCa4TeX82YMQ+tcx5r0KZvHODSFPOZT7SLOgUjnImHLfIxmMWwQo?=
 =?us-ascii?Q?2ttXWyMU5MSnJD4zzH/X3lQZlXvmBv7DGggxwZWu52rjj088v2KjtV+zvgIe?=
 =?us-ascii?Q?FOG8uHQRQIIDESJ/9PAq6O3TUSzK6ROdx5BEYK4frvt20imc7K4IBScC6oEk?=
 =?us-ascii?Q?pVMRMWe9Xu841RPy31YyXGAKZccUaaw6mvajXemDWRM6jg42IO6JXZGcMaaM?=
 =?us-ascii?Q?fgNy9TEjl/+oh5SB4kc80Tme14gGKkc/eYGTZQsmsNgMwiRxoGl6niKIemCs?=
 =?us-ascii?Q?hFJ88Azl0tEjPLto/IhEI79vxc3gajT7cNcFOT2ao4kUrrCPgm298j0avYd7?=
 =?us-ascii?Q?qvrFVgNPFAM6tor+jId94TfkXlmBcgKlq6fQFNyTC0FPORBWezcQN3iLID82?=
 =?us-ascii?Q?ThWudRvEZPDw0IX3HADRwBiBuFSIzPkQ3C3fpSSTWbFToq14QKa6I9tj3bEb?=
 =?us-ascii?Q?SfRMqOGcntEaR6IY25w9OHsltSJrZ7gDJlZBjIvHbLI/Q/nNEemJLhkMDYxP?=
 =?us-ascii?Q?ZBk8f3rgCfKK2T6tDI8V//yKsi+j4ECpSRim4ZnxPYWHqHvctyxMHIwCIumz?=
 =?us-ascii?Q?EtyLmF+Kht8lqbArsSq0ki/Uws9SFGQQTt+XDbP3708LVmNdtm+fT48aQyqs?=
 =?us-ascii?Q?CdmJX9ckqElImExo8D+BaLR0+fJorTCUjx+ATWGNI9A48ctXhznJzRGRw6LN?=
 =?us-ascii?Q?sQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1801MB1880.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ec4df463-492f-4882-1e13-08d998652e6d
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2021 09:44:18.5678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LhEEET9fImHYvTVegmzkylocP+j15b9Z5AX0efTbqpNKXnOJcCJEiz4XVWXxmx4Bk0sXPUKZXa/f55VJOp+L6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1111
X-Proofpoint-GUID: RTe6v9JgvEtLTICGKUPNpFTHeAZvCgxF
X-Proofpoint-ORIG-GUID: RTe6v9JgvEtLTICGKUPNpFTHeAZvCgxF
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-26_02,2021-10-26_01,2020-04-07_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

Please see inline.

Thanks,
Rakesh.

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>=20
Sent: Tuesday, October 26, 2021 6:43 AM
To: Rakesh Babu Saladi <rsaladi2@marvell.com>
Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.o=
rg; Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula <gak=
ula@marvell.com>; Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Hariprasa=
d Kelam <hkelam@marvell.com>
Subject: [EXT] Re: [net-next PATCH 1/3] octeontx2-af: debugfs: Minor change=
s.

External Email

----------------------------------------------------------------------
On Tue, 26 Oct 2021 00:44:40 +0530 Rakesh Babu wrote:
>  	cmd_buf =3D memdup_user(buffer, count + 1);
> -	if (IS_ERR(cmd_buf))
> +	if (IS_ERR_OR_NULL(cmd_buf))
>  		return -ENOMEM;

memdup_user() returns NULL now?

Rakesh > I checked now. It is not returning NULL. I'll revert this change.

>  	cmd_buf[count] =3D '\0';
> @@ -504,7 +504,7 @@ static ssize_t rvu_dbg_qsize_write(struct file *filp,
>  	if (cmd_buf)
>  		ret =3D -EINVAL;
> =20
> -	if (!strncmp(subtoken, "help", 4) || ret < 0) {
> +	if (ret < 0 || !strncmp(subtoken, "help", 4)) {

The commit message does not mention this change.
Rakesh >> ACK. Will address this in v2.

>  		dev_info(rvu->dev, "Use echo <%s-lf > qsize\n", blk_string);
>  		goto qsize_write_done;
>  	}

> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c=20
> b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> index 7761dcf17b91..d8b1948aaa0a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
> @@ -2583,6 +2583,9 @@ static void nix_free_tx_vtag_entries(struct rvu *rv=
u, u16 pcifunc)
>  		return;
> =20
>  	nix_hw =3D get_nix_hw(rvu->hw, blkaddr);
> +	if (!nix_hw)
> +		return;

This does not fall under "remove unwanted characters, indenting the code" e=
ither.
Rakesh >> ACK. I'll address this in v2.