Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211026032304.30323-1-qiang.zhang1211@gmail.com>
In-Reply-To: <20211026032304.30323-1-qiang.zhang1211@gmail.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Tue, 26 Oct 2021 18:32:38 +0800
Message-ID: <CAMZfGtUXq=nQyijktRaP7xp=sAmVCryTjU4Jo5Z=ufed8arnKQ@mail.gmail.com>
Subject: Re: [PATCH] io-wq: Remove unnecessary rcu_read_lock/unlock() in raw
 spinlock critical section
To:     Zqiang <qiang.zhang1211@gmail.com>
Cc:     Jens Axboe <axboe@kernel.dk>, asml.silence@gmail.com,
        io-uring@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 26, 2021 at 11:23 AM Zqiang <qiang.zhang1211@gmail.com> wrote:
>
> Due to raw_spin_lock/unlock() contains preempt_disable/enable() action,
> already regarded as RCU critical region, so remove unnecessary
> rcu_read_lock/unlock().
>
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
> ---
>  fs/io-wq.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/io-wq.c b/fs/io-wq.c
> index cd88602e2e81..401be005d089 100644
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -855,9 +855,7 @@ static void io_wqe_enqueue(struct io_wqe *wqe, struct io_wq_work *work)
>         io_wqe_insert_work(wqe, work);
>         clear_bit(IO_ACCT_STALLED_BIT, &acct->flags);
>
> -       rcu_read_lock();

Add a comment like:
/* spin_lock can serve as an RCU read-side critical section. */

With that.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.

>         do_create = !io_wqe_activate_free_worker(wqe, acct);
> -       rcu_read_unlock();
>
>         raw_spin_unlock(&wqe->lock);
>
> --
> 2.17.1
>