Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans
 multiple pmds
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20211020054942.1608637-1-quanyang.wang@windriver.com>
 <CACRpkdYxMDp4FRGP=EOt8oTMxs_YuskbvMx5wXBDjUWz6hD=gQ@mail.gmail.com>
 <YXfDdmrCynZk/QW8@shell.armlinux.org.uk>
 <cddc3cd6-a36d-e02f-4cd8-26ff15e72d13@windriver.com>
 <CAMj1kXEyc0S6A_OQRQOTtTFxev=Kj55Zhn2dRDaZ6FP+Ek=17w@mail.gmail.com>
From:   Quanyang Wang <quanyang.wang@windriver.com>
Message-ID: <8905597e-49a9-c898-c78d-3d2f51180133@windriver.com>
Date:   Tue, 26 Oct 2021 18:38:16 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAMj1kXEyc0S6A_OQRQOTtTFxev=Kj55Zhn2dRDaZ6FP+Ek=17w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVZGWVY5OVMzMXBSWldua25jb1VWNE9lWGc5bUJaTGZSY08xM05ndzBHNDdh?=
 =?utf-8?B?bU12SXlhelBuVmZXQlFqK1grQkRSWFBXendYem9MQ2ttTUs1VzRZU2NOL3RC?=
 =?utf-8?B?bkN6bVo1MWREclgyUG5JTHVSVlVRZTZYSkRyOVVZTng0UDJMRFVSYXVCNlI0?=
 =?utf-8?B?VnlTbExkNHd4Q09vVnA4cXh1VitFSFoyWlVmK3NIRThMMUxVZ1Joc1hQNmRz?=
 =?utf-8?B?cXl5QjltdUVSMGJVSUhyZ2Z2T2t2S1EwVHo2MWU2NE5Fb3R2eVJuQXdMSExF?=
 =?utf-8?B?T2srOWtUcTgxSWdpcU9BbUgvaDZJeUpmMSs4c29YSXA5RmYxeUNhMklBcU15?=
 =?utf-8?B?R0d6SkRvSnhISGJqM1lZTmRZcVJ4VVE4VWxYMGxJb3JWZTRqSzVYT0FhWmNQ?=
 =?utf-8?B?SmNnNUhpRElaVmJhTWZDdkQySDRNbkdPMHRmZkVjMVpSRDd4NkJUa1h1UktQ?=
 =?utf-8?B?YVhHWWd4L0ZHVEVUN0l0aDYzcW1NUlVsVCtUcnFMSUR3cTk5L1hHWk5aM25y?=
 =?utf-8?B?K3hhME91WDd5aDdtMkdJYXFyRkFkU3JmdXVSUnExbC9QQzkzNHVoR1V2eXBs?=
 =?utf-8?B?RUR1S014RHpmcGpzaDBEMGhhdlZmenh3OVJod2gvZjdwdS90aXl5d1ZOSUp3?=
 =?utf-8?B?YkJBZldPWTZaZkFWbUMwME9PRzZKYU8xMlZ0emhYekFNY2drTXhESnJJa0s4?=
 =?utf-8?B?UnpTVjZpOUx6dUNIVlQ0eTJxZUsxK0hFWUdDRUFQaHI5UzBFUE5oa2VGSFYy?=
 =?utf-8?B?dVdDZUlQamxuVzY0dDhHMmhSQjg2TnZORG5kN09LYm0wZ1RHeUxHeE9LU0lP?=
 =?utf-8?B?UGJDVzhCNjFjQUlaTjJBbkVMNWdUcWhzWGY5R25Xb2JMMlRyN3ZJNjU4ZUlZ?=
 =?utf-8?B?eERVb245NXJQbHQ5U3F1KzZEenRRVzdFQ00xK3kyd2xvU3Jjb1hyTm1rM3lX?=
 =?utf-8?B?V0p3NnZGMmV0TzZhOG0wUCtUOTdFZWE4TlFuaTY5c2Y2dTM1VWl2MFNnVnp0?=
 =?utf-8?B?RFZMQkdJajlZWnUzTHMrMUtONG01bGFpZDZhZzJOWmxtcVJ0UTFXcXhCYXA1?=
 =?utf-8?B?T3oxbXlXUU11K1gwczBQSFI1cHpnNkpSSW00NlpGeU1uSHFNRkw3TDhJbkpX?=
 =?utf-8?B?UmlrRnpoa0JqdVhJbi9SMFBVeVVJRFB2TUU4YmJlOHNIWTdUNEFZTEhmL2kr?=
 =?utf-8?B?SzdEbVcyMythMllNamx4S244T2l4dG9hckFaU2d2ZkdiRU5rQlZVeHhhZWgw?=
 =?utf-8?B?U2p4WHpaNXBnNzVtdFNpR1FPNHd6MkR0cDQxUWRob0RDNHorN2hoV2EwRzFX?=
 =?utf-8?B?Y1dTeHhvc2V3Uzd0alFzWkozNXA5QTJ6SXBueTdIeVhjWkJPb3V6RlRsQTc0?=
 =?utf-8?B?WjFGMzByQlp3Zlk2azZxbkcvRnZ3VzBLQk9CZHJ2bnVaTlhtT3k0dHV3VHUy?=
 =?utf-8?B?c1V1T0IxOWRQaVdwTnNiaFVpWHRrMzA2Q2I2UUFMbkhsaTIxS1ZEeUx1cUI5?=
 =?utf-8?B?YWd6bVlpb0pGYWlhMWlkUnd2L1VFRlM4QmU5bkJWV3BqL2N3UzQ1UG1aNm0x?=
 =?utf-8?B?dVlPS3RxWlBwRU5NcHFMVnpzb0VoZExybDhseHNxWTNGb2xFejhRNEdSbWVN?=
 =?utf-8?B?aGpSVmVsQ3hjUlZKNnY1QWd2N0kyTkFnREZLdzRtRzgyV3Vmckk3THd0ekda?=
 =?utf-8?B?U3RUN2MyVWlRbFovdDdoNzJGV25tVkJiRmpSR1NMSHlPdHgvWVhQVUlHUGYr?=
 =?utf-8?B?bEZwNm12bk80SGNHUEZqTTk2V05KMmFkcTI4MlBNZXpqK1E0eEhmdmxwWGgv?=
 =?utf-8?B?dkhzcmllakJrOGVtVVJnemNURWM3Rm5SeER3STVmVnlVLzFCSGRlbThxeXRB?=
 =?utf-8?B?S3Rrd3lsQ0piaUoxTkJCdnNZdUhlL2dkWnlCRnlTdlJaQ2hrVmV3Rzl4WjN4?=
 =?utf-8?B?UzFMeTFrNDRFTFpPYzZKOGNYNXNqS2FtMjBRRnM4NzFma1lOVThjeTB1c2xD?=
 =?utf-8?B?SllQb0Fkdlo5ZE5MQlh3YVlORVViK2UxTmREOHlVUnhzTm9hV05URmRQMzlu?=
 =?utf-8?B?amNaeWUySnBRZjdnNUQ0UFY4cDNvcmNtOXVzZCtqTVE3RkRTOC9RYXF6Q204?=
 =?utf-8?B?aU1wakVDNWt2N00xdzZZbCt6dUo4RGZlNGY3MmFhbnFveG8yeElFeGZScE0v?=
 =?utf-8?B?OXZUM0YyVStZT0VzWnNtVU81cTRYMjViUWpodk41WXVBUTlsa0JvMmV3VEVM?=
 =?utf-8?B?TDVwUHRoWTFWUG9SaVUzNGdGckV3PT0=?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18d39855-25d3-4d03-b95b-08d9986cbd40
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 10:38:25.0095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +XYMK8qrVIIJeqN6FrCupKyJ8dg533Qs7Ce4dgrH2YPJt33y/DvxRbHAUYovR7j3RV1htsK1sxzlVy9bJqEmbkHAucpr4hvkQgPte4NAz+0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5015
X-Proofpoint-GUID: jvATNMsemRBiwfej0akCKkJhywNC3xvf
X-Proofpoint-ORIG-GUID: jvATNMsemRBiwfej0akCKkJhywNC3xvf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-26_02,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0
 spamscore=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0
 adultscore=0 lowpriorityscore=0 mlxlogscore=840 malwarescore=0
 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110260060
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ard,

On 10/26/21 6:12 PM, Ard Biesheuvel wrote:
> On Tue, 26 Oct 2021 at 11:53, Quanyang Wang <quanyang.wang@windriver.com> wrote:
>>
>> Hi,
>> Sorry for the inconvenience.
>>
>> On 10/26/21 4:59 PM, Russell King (Oracle) wrote:
>>> On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote:
>>>> On Wed, Oct 20, 2021 at 7:50 AM <quanyang.wang@windriver.com> wrote:
>>>>
>>>>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>>>>
>>>>> Not only the early fixmap range, but also the fixmap range should be
>>>>> checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM,
>>>>> some systems which contain up to 16 CPUs will crash.
>>>>>
>>>>> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
>>>>
>>>> Looks reasonable to me.
>>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>>>
>>>> Please submit this patch into Russell's patch tracker.
>>>
>>> ... and has totally broken what looks like _all_ ARM kernel builds.
>> This patch is intended to trigger build error when it check the value of
>> __end_of_fixmap_region is equal or larger than 256.
> 
> Why? The fixmap region is larger than one PMD, so why do we need to cap it?
In __kmap_local_pfn_prot, arch_kmap_local_set_pte(&init_mm, vaddr, 
kmap_pte - idx, pteval) is used to set pteval.
But the ptep is calculated by "kmap_pte - idx", which means all ptes 
must be placed next to each other and no gaps. But for ARM, the ptes for 
the range "0xffe00000~0xfff00000" is not next to the ptes for the range
"0xffc80000~0xffdfffff".

When the idx is larger than 256, virtual address is in 0xffdxxxxx, 
access this address will crash since its pteval isn't set correctly.

> 
>> In fact, it breaks the ARM kernel builds which NR_CPUS is equal or more
>> than 16. If CONFIG_DEBUG_HIGHMEM is enabled, all ARM builds which
>> NR_CPUS is more than 8 will fail.
> 
> You really need to be more specific about the failure mode here.
OK, I will be more careful about this.

Thanks,
Quanyang
>