Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 12:51:04 +0200
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Denis Kirjanov <dkirjanov@suse.de>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Ahmed S. Darwish" <a.darwish@linutronix.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Zheng Yongjun <zhengyongjun3@huawei.com>,
        Eric Dumazet <edumazet@google.com>,
        Randy Dunlap <rdunlap@infradead.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net-next v3] net: sched: gred: dynamically allocate
 tc_gred_qopt_offload
Message-ID: <20211026105104.vhfxrwisqcbvsxiq@linutronix.de>
References: <20211026100711.nalhttf6mbe6sudx@linutronix.de>
 <3bf1e148-14fc-98f6-5319-78046a7b9565@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <3bf1e148-14fc-98f6-5319-78046a7b9565@suse.de>
Precedence: bulk

On 2021-10-26 13:42:24 [+0300], Denis Kirjanov wrote:
> > diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
> > index 72de08ef8335e..1073c76d05c45 100644
> > --- a/net/sched/sch_gred.c
> > +++ b/net/sched/sch_gred.c
> > @@ -311,42 +312,43 @@ static void gred_offload(struct Qdisc *sch, enum tc_gred_command command)
> >   {
> >   	struct gred_sched *table = qdisc_priv(sch);
> >   	struct net_device *dev = qdisc_dev(sch);
> > -	struct tc_gred_qopt_offload opt = {
> > -		.command	= command,
> > -		.handle		= sch->handle,
> > -		.parent		= sch->parent,
> > -	};
> > +	struct tc_gred_qopt_offload *opt = table->opt;
> >   	if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc)
> >   		return;
> > +	memset(opt, 0, sizeof(*opt));
> 
> It's zeroed in kzalloc()

but it is not limited to a single invocation?

Sebastian