Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] dma-buf: remove restriction of IOCTL:DMA_BUF_SET_NAME
To:     guangming.cao@mediatek.com, sumit.semwal@linaro.org
Cc:     dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
        matthias.bgg@gmail.com, rdunlap@infradead.org,
        wsd_upstream@mediatek.com
References: <20211012084109.176542-1-guangming.cao@mediatek.com>
 <20211014102551.54983-1-guangming.cao@mediatek.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <0e062f12-7e79-5a05-1e7b-10dda8e353b7@amd.com>
Date:   Tue, 26 Oct 2021 13:18:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211014102551.54983-1-guangming.cao@mediatek.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vkc5cXdzS3Izek5iOGxaTGZzU0JwSEZ2M0lXTHQ1eGJkK2VaenhYNnFubkNF?=
 =?utf-8?B?MEFTZWN1amMzVjkxVy8vRnlKSUVlNGh3WXo1SE9GdGhFdmMzOGZRNzR2bk1I?=
 =?utf-8?B?K1pDdis2RUZFSXlld3pvL01NREJ4OU5JRjhrZExXNGZ6ZWxHQVN1b3JwUFpy?=
 =?utf-8?B?aEhBcG5Tc20zaHQ5OGJ5QzBHU01qVHRKdlpwRlpucUNnaEU5ZSsycGJYTWVT?=
 =?utf-8?B?ZUFGZm9YSkw5MnFYaGxTMmJIeGdYVTM0RWRnbi9QNUxId1UyQkwyTkRmUzNL?=
 =?utf-8?B?TjdLVDNBcktrcDBpUGNaejhTaG5VMVBHL255MUVFT3RiRHFPdFFQS1RxbEJL?=
 =?utf-8?B?V21Lb01tQjJEaTRaRmw1dFVBSXlxZ2JLVldBYUZSQ0F3Q0psUWlwVkw5dWxu?=
 =?utf-8?B?OHEzOU56WnZIVG5mMXpEUTRYR1BkWmRrd1dkcHBoM2NmdmdCS0ZTRUVwZEtt?=
 =?utf-8?B?ZkVwRnJad2dmWEcvbld0MldybVpBNTYzUEJOYlhxNGZlcFVkZUxMdnRBZFEr?=
 =?utf-8?B?aG1jSDFFZGQyV0NvcE5qbDVkMk9JbWpoaWprVnZlZTF1WHBuSjFyb1FYalNp?=
 =?utf-8?B?bWxaS2dwRjNSdlkrWlJnZ0laY2tlb3ZWelBtQlVmLzZwL3loTFMyYzZRcmRC?=
 =?utf-8?B?OUVMcTN5b2dtRHl2Q0p5UG9zNmZhK3NoTk91WmZlYXBzaExWY3AxcHJoMnNZ?=
 =?utf-8?B?bmRPNEJpVHgwcWlPRUY3WndVanFZM3RjaEFpOEZ3Sm8vUVJwNmF1bHRWV0NK?=
 =?utf-8?B?cWJ5K0twbjJzOXRnaktnVElKVlJhVklzdzJJY25GQUFzZVl5WWk4MDFneU9w?=
 =?utf-8?B?Vk1uL21CcEc5emN6bFl4d3BlakpKc2lueUdkM3pQRE1jeTd5Y3lPQVFEek5q?=
 =?utf-8?B?Q1lyMUk4enJrY3o4SlBBNXdKK3d6WG5Sck55ZG00cHJpMmhJTWxwalFtMzU1?=
 =?utf-8?B?SXdpQXJzVWFudFdYUGtHeVM0Y250VVNPNUNUcUVxaTZkUmw0Vyt3NnprKzUr?=
 =?utf-8?B?UDJuMk1Zc2hRdEhmVlR6OW9Ydkp6TTNkaGdNbjJRWXlQcUNSejN2UEpjMFM2?=
 =?utf-8?B?em1vT2R2TFFRRUxTQ3diQ1NNL0tpTVV1elRiMmFtb2pjK0lBZGloZW1GUVZR?=
 =?utf-8?B?YWxYTUx5OFZES1hKQllNOFdjMVVZOEFVWXZXblhIT2t5Vkk2d2FnSVlKZzN4?=
 =?utf-8?B?Y1FLWTlEM2kxdWpuZk5qdnZqSExPdWlyS2pjVzJCZWRNVkhTaXJ1UDI1Szc5?=
 =?utf-8?B?NDZwcXZZdmFiYmo2dW4rdVpaVVVJczV2SkZiYWZrWUx2RXdzRWRPTGxEaFJC?=
 =?utf-8?B?NW1hdWxRTnVEYkUySXJQT0FlMTYxdjI3UXptT0dIUmZLWlZyTnh3SkhFSml2?=
 =?utf-8?B?Y0pQTG41QTNIOTRjOExvVDY5cWpMV3ZpTy9DRFQrNjRqTHZqMEx5Q1IrVWtO?=
 =?utf-8?B?NEtReFdqMzA1RnF1OEUrOFBJSEp6RmY3eVVXdWR1WUJJUlRBWDl5UFpZcWR5?=
 =?utf-8?B?MjZhaFlmaW9IWnNRM1NBWWVEa3RXWXdJRkduNG1lc2o0SjB2cU5teEQ1bWJN?=
 =?utf-8?B?ZkVqWXEwRXRQQjMyTWtIRDk1a0J3aGVqYXRuNFY4UGJnemV1WDFncCszS2lr?=
 =?utf-8?B?bmwvdk0ra1JqTGZoQnVMTGozTGtudGVBNWNXOHMwVHRkczNReWc3cXFRSkxl?=
 =?utf-8?B?L014eVEzaXZIZStDQ1pqS2IxaGtGaGNTL09DZERqNXowREh6ZDd1em5mVDdp?=
 =?utf-8?B?eHI1NHgyUDVMTERlNUtGMHZhK1oyUjBORWwwOHpHQ090eDlQcjZYUFdXZStZ?=
 =?utf-8?B?Zi9WVTdmYnE3UlA0QlpWbXB2NTBjU3doQWk3bDlQWTlUbTV5VVVTRitqRXBq?=
 =?utf-8?B?eWl3ZXNrV2swbURPUVRROFFUZysxcjRlMHJpNHB0S2xrU2JMdStUL0JIek9G?=
 =?utf-8?B?OHN1UktXdGlHTmVnNXZicDA0WFdzc2VMSWlPS2JkSDZ2Wm1xYWR3SCtpUjNK?=
 =?utf-8?B?WEl5NXEwWlAycVA5OXpYcmVKRVljalpFTWJJczdKNW1QWEE4N1BuNTI3Nkxv?=
 =?utf-8?B?ZERVQVN1R1B6cjY3U241QytaYi9JeGdCMEY3d1BmUTgwc2NKTitubTRiYXJH?=
 =?utf-8?B?Qm1YMjBjT003ayt5ajZqSG1uT2swa092VXhpTHVxZmQ3N1lqYlR6am5LY0ZB?=
 =?utf-8?Q?CgmapkGlkaEanPFOIudZgHU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01341e0b-2847-4214-fe21-08d998726a39
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 11:19:02.7834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jMFfbPJqt46DFs4/pSsoYY4wzJl1hISpMgtbuGKX7TQM/SIUGfjbJqn4dv6/m7Xw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1839
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.10.21 um 12:25 schrieb guangming.cao@mediatek.com:
> From: Guangming Cao <Guangming.Cao@mediatek.com>
>
> In this patch(https://patchwork.freedesktop.org/patch/310349),
> it add a new IOCTL to support dma-buf user to set debug name.
>
> But it also added a limitation of this IOCTL, it needs the
> attachments of dmabuf should be empty, otherwise it will fail.
>
> For the original series, the idea was that allowing name change
> mid-use could confuse the users about the dma-buf.
> However, the rest of the series also makes sure each dma-buf have a unique
> inode(https://patchwork.freedesktop.org/patch/310387/), and any accounting
> should probably use that, without relying on the name as much.
>
> So, removing this restriction will let dma-buf userspace users to use it
> more comfortably and without any side effect.
>
> Signed-off-by: Guangming Cao <Guangming.Cao@mediatek.com>

We could now cleanup the return value from dma_buf_set_name() into a 
void since that function can't fail any more as far as I can see.

But that isn't mandatory I think, patch is Reviewed-by: Christian König 
<christian.koenig@amd.com>

Regards,
Christian.

> ---
>   drivers/dma-buf/dma-buf.c | 17 +++--------------
>   1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> index 511fe0d217a0..5fbb3a2068a3 100644
> --- a/drivers/dma-buf/dma-buf.c
> +++ b/drivers/dma-buf/dma-buf.c
> @@ -325,10 +325,8 @@ static __poll_t dma_buf_poll(struct file *file, poll_table *poll)
>   
>   /**
>    * dma_buf_set_name - Set a name to a specific dma_buf to track the usage.
> - * The name of the dma-buf buffer can only be set when the dma-buf is not
> - * attached to any devices. It could theoritically support changing the
> - * name of the dma-buf if the same piece of memory is used for multiple
> - * purpose between different devices.
> + * It could support changing the name of the dma-buf if the same
> + * piece of memory is used for multiple purpose between different devices.
>    *
>    * @dmabuf: [in]     dmabuf buffer that will be renamed.
>    * @buf:    [in]     A piece of userspace memory that contains the name of
> @@ -341,25 +339,16 @@ static __poll_t dma_buf_poll(struct file *file, poll_table *poll)
>   static long dma_buf_set_name(struct dma_buf *dmabuf, const char __user *buf)
>   {
>   	char *name = strndup_user(buf, DMA_BUF_NAME_LEN);
> -	long ret = 0;
>   
>   	if (IS_ERR(name))
>   		return PTR_ERR(name);
>   
> -	dma_resv_lock(dmabuf->resv, NULL);
> -	if (!list_empty(&dmabuf->attachments)) {
> -		ret = -EBUSY;
> -		kfree(name);
> -		goto out_unlock;
> -	}
>   	spin_lock(&dmabuf->name_lock);
>   	kfree(dmabuf->name);
>   	dmabuf->name = name;
>   	spin_unlock(&dmabuf->name_lock);
>   
> -out_unlock:
> -	dma_resv_unlock(dmabuf->resv);
> -	return ret;
> +	return 0;
>   }
>   
>   static long dma_buf_ioctl(struct file *file,