Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1430241pxb; Tue, 26 Oct 2021 08:53:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQwvoBjMCRMM4aV6qUNH/FMnQP2XTt36gBFUFLVP/F8/w8MV/c+rzc8heM2OLuWeSlalTF X-Received: by 2002:a17:907:6da3:: with SMTP id sb35mr30043479ejc.519.1635263589211; Tue, 26 Oct 2021 08:53:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635263589; cv=none; d=google.com; s=arc-20160816; b=Ra2wkSSIaHECrUOiDetb8EbMqQ94B9FKfERix8RKrRaij3bX0nC1cjaDIFKLdZldPd wLAvOkAWlhPNPU9Yq8kOWB7dVnj2gfD9xoIj3xT25VD480fqSBWWscoAXhBaAg3Gdopl w3lVgVyOQo7LomUkpjZfxh1MvQY0CjPfXPWSk841DcppF6xFiXOCtS08O9u7tsAGjc/u b3hE+NlstdsEAY8ucvdxDw6+88twlllKlWLSCMMkupUQwaAzPQC7UVX7KnhE3s6aGhTY QG8gQskMoDX6mJ6fJbbp4T/pvLB42ZibVTdPajNzj4zj1R2N+l88BPXL/GkGl3poLRVh oMfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=vtHZvrer1s/ryaMyVVdQlA3Y5wmK+Xyig0j8gFNvscY=; b=jPWbF0sRglJcjSUQGmInhuGq4BeLYVL4j0ZcEfjz9ruEuObQ5Wug6COQLIfjmv3Rz2 lhIscb/MuAyPPyCeZwHUd81/SlG4Neyy03Gj6Hx6GRMqQK+CUmFcr05N8MRv3/90AWob imBNqnYKVz3x+BIWfFaiReutj0AwrwrRquxkvY3HP0yGnhsxovX9Cy6qdpT1HzYkR04C CVwYEHkzzZlF5vUluTERjgINopclLMIhvi576y+ChJ/FYlPHuwoHxXGVElLaimRP5Yg/ my5hgHReN4J78ypzeHyMJPkw+iG6uBS9vGa+qpILa/V9Nv0J9fuP54WG9U2QK66wuCaB gpFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka7si15710379ejb.79.2021.10.26.08.52.43; Tue, 26 Oct 2021 08:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235626AbhJZMIY (ORCPT + 99 others); Tue, 26 Oct 2021 08:08:24 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:25313 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235730AbhJZMIA (ORCPT ); Tue, 26 Oct 2021 08:08:00 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Hdr4m0DZ8zbhFs; Tue, 26 Oct 2021 20:00:56 +0800 (CST) Received: from kwepemm600001.china.huawei.com (7.193.23.3) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 20:05:34 +0800 Received: from huawei.com (10.175.104.82) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 20:05:33 +0800 From: Wang Hai To: , , , , , CC: , , Subject: [PATCH net-next] ice: fix error return code in ice_get_recp_frm_fw() Date: Tue, 26 Oct 2021 20:23:33 +0800 Message-ID: <20211026122333.3017952-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600001.china.huawei.com (7.193.23.3) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return error code if devm_kmemdup() fails in ice_get_recp_frm_fw() Fixes: fd2a6b71e300 ("ice: create advanced switch recipe") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/ice/ice_switch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c index 2742e1c1e33..373bcb5e4f4 100644 --- a/drivers/net/ethernet/intel/ice/ice_switch.c +++ b/drivers/net/ethernet/intel/ice/ice_switch.c @@ -1177,8 +1177,10 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, recps[rid].root_buf = devm_kmemdup(ice_hw_to_dev(hw), tmp, recps[rid].n_grp_count * sizeof(*recps[rid].root_buf), GFP_KERNEL); - if (!recps[rid].root_buf) + if (!recps[rid].root_buf) { + status = ICE_ERR_NO_MEMORY; goto err_unroll; + } /* Copy result indexes */ bitmap_copy(recps[rid].res_idxs, result_bm, ICE_MAX_FV_WORDS); -- 2.17.1