Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net] usbnet: fix error return code in usbnet_probe()
To:     Johan Hovold <johan@kernel.org>
CC:     <oneukum@suse.com>, <davem@davemloft.net>, <kuba@kernel.org>,
        <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20211026112526.2878177-1-wanghai38@huawei.com>
 <YXfsclAOm8Zhbac1@hovoldconsulting.com>
From:   "wanghai (M)" <wanghai38@huawei.com>
Message-ID: <f7eec28b-1e4a-c03b-3503-39efff9d45ff@huawei.com>
Date:   Tue, 26 Oct 2021 20:17:24 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <YXfsclAOm8Zhbac1@hovoldconsulting.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


?? 2021/10/26 19:54, Johan Hovold д??:
> On Tue, Oct 26, 2021 at 07:25:26PM +0800, Wang Hai wrote:
>> Return error code if usb_maxpacket() returns 0 in usbnet_probe().
>>
>> Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
>> ---
> Good catch. This is embarrassing. I double checked the error path but
> failed to notice the missing return value.
>
>>   drivers/net/usb/usbnet.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
>> index 80432ee0ce69..fb5bf7d36d50 100644
>> --- a/drivers/net/usb/usbnet.c
>> +++ b/drivers/net/usb/usbnet.c
>> @@ -1790,6 +1790,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
>>   	dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
>>   	if (dev->maxpacket == 0) {
>>   		/* that is a broken device */
>> +		status = -EINVAL;
> But please use -ENODEV here. -EINVAL is typically reserved for bad user
> input.
Ok, I will send v2
>>   		goto out4;
>>   	}
> Johan
> .
>
-- 
Wang Hai