Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1450594pxb; Tue, 26 Oct 2021 09:13:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ5f57IQc6MQzwsd6qw/oLOahZlSjcqFh1p22c677g88AofsRb4KI/l6lC2ILqZ3rrtNeW X-Received: by 2002:a17:903:18f:b0:140:658d:851d with SMTP id z15-20020a170903018f00b00140658d851dmr8451861plg.47.1635264794440; Tue, 26 Oct 2021 09:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635264794; cv=none; d=google.com; s=arc-20160816; b=Yw9LoKi19mqJvobhNAM7TsHbsTpJgXzihSNWms6oOoBJj8FjtRkGi/levD1rs1mmvh i3disBFIGqj+prQkCPPaRfRZMhRRWLJOq6JDX4hjoSdo9qNmeX7pPx8tZZGkZMKD9IX9 HisZ+WigHnNPXzFRJ0eqwzH5oQf+Qq5OuI93LKUpiyvlZDqUrY6yQqsJPUe/t0Jw70ra SqiiQWbpH4S+KePtmARhBc1iuJTWEwn0/Oc38lvIzypN3Mdv1M6oWEwRt877jsXh67W2 vwcWTaim7mBgyOO22YqBa9axGALo+YD0Jvt0Ao4dlkJ8rYYTbU/0eNwBnwk1DD4unbNn 0XeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=oNhm8/5a04ICJRn4GRtUlJMkK/6x7C6PesmRc3coTxM=; b=OTVU40e5q5vjVTJL9gJ2/KUt/QUMhTYMPeFquENdTlnLJLrSgx+BbA/WKVTpp9MG1o oiYQ3qic75kgWs4V6zWcIyQ7R8ssyAqWjCfYi0WX/6Ok7VHVEtEAgI0ui0FMlyGsIb06 xQNp7aUuxk2XooBR/NiNnpuwqcNr6ejFw4MiNIXLn+BOJ5Xnn4gerVEyp1Ekfifgx6Ki z4X5nnAs5l7p+KVR1gZbnp4t8uNSKulsKkJQ2uMLrjodAE8825oLwd+V6MvWIlng0gTk jqD3xBYVNNAQXdpGS92NqWvlWdvEe53neNmwkN80x1to7qGYHqA1r9tL25yTv90gDR1A NRqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ThoO8NsE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id np15si1569080pjb.54.2021.10.26.09.12.55; Tue, 26 Oct 2021 09:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ThoO8NsE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235889AbhJZMWd (ORCPT + 99 others); Tue, 26 Oct 2021 08:22:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:42332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235883AbhJZMWb (ORCPT ); Tue, 26 Oct 2021 08:22:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id B4EB661057; Tue, 26 Oct 2021 12:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635250806; bh=40fY76V4SlvvS83hpSYE6HKAN0YPV+WRGoLc/HDIkmI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ThoO8NsEq/hCWGl+OprwJoQ6qFpYtn/vdo1ip+z883V7NB8kGoMecNokxtTr/SY8i ALyDO1YrJExG/xJ163pDiEB0JJzIGxrpivnKdYbiFcWlDRLWDmeKmXOKkgvRr8czix bptg9ajpkWYKYcRp7A5Da8xZF3qpE0mdqJB5MNMPXqDgCKaITHOaPMU53nuVwgfw3I lUt+knM7RU9W+s2wH7NBuu2tCC63HZQ6yn6nnB9n8U841P4NNiseI0LgUwpMD0SBPG UGMKwNPoJge1bHYIwJyZW5i1lPBYXaGP3VdSNfGh/2tvFZo+EqcyTU6IFmZQ7bkrw0 TXrvopQsGu5Ag== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id A8F44609CC; Tue, 26 Oct 2021 12:20:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [net-next v1] tcp: don't free a FIN sk_buff in tcp_remove_empty_skb() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <163525080668.27254.5317697458188609155.git-patchwork-notify@kernel.org> Date: Tue, 26 Oct 2021 12:20:06 +0000 References: <20211024235903.371430-1-jmaxwell37@gmail.com> In-Reply-To: <20211024235903.371430-1-jmaxwell37@gmail.com> To: Jon Maxwell Cc: edumazet@google.com, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Mon, 25 Oct 2021 10:59:03 +1100 you wrote: > v1: Implement a more general statement as recommended by Eric Dumazet. The > sequence number will be advanced, so this check will fix the FIN case and > other cases. > > A customer reported sockets stuck in the CLOSING state. A Vmcore revealed that > the write_queue was not empty as determined by tcp_write_queue_empty() but the > sk_buff containing the FIN flag had been freed and the socket was zombied in > that state. Corresponding pcaps show no FIN from the Linux kernel on the wire. > > [...] Here is the summary with links: - [net-next,v1] tcp: don't free a FIN sk_buff in tcp_remove_empty_skb() https://git.kernel.org/netdev/net-next/c/cf12e6f91246 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html