Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1451147pxb; Tue, 26 Oct 2021 09:13:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxw8SBBuFzocapNbOsIE+nvqGs6AQg7m2fTV3qd5brw5hnQ9hZabASU4IisUxYlDZ7M5p/4 X-Received: by 2002:aa7:924d:0:b0:47b:d390:da8d with SMTP id 13-20020aa7924d000000b0047bd390da8dmr23550428pfp.15.1635264826972; Tue, 26 Oct 2021 09:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635264826; cv=none; d=google.com; s=arc-20160816; b=fL8LHEz49zNIwVhqoV9UXuwrNTMe703IuYyTABH9ialUu5yv6388zvrhEe1SKLFTGN EbVSEdMeuextHlCyuFa2ypddt/m53+NVoIx8XQX8bipNEM9keIb22m6ACd6xy4tCq35b U17p9svrOM8MQMRwHDXUZjO7F9tcW+y0957QXl+hmbebLVm3ggCFmz5tJw+A7ny1atDs STTQtFyD8cNxXzA6DGQbjDmVJAm9v4OaeT6ge6s+VkJNJX0Efy6YcUk4rQ3sWLfDOtYF eS7AaYwgkvCg1pewU1+wheFFKDXErfo4Vk4bfZ7ZWqlNpHXCdIt0aIltEXc0Cqeb+b6R KgdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=haxKzbFd45KWun+tfXgEZEjwxHUYfnkaYRX8AqOzHbQ=; b=Z5Kufe8zNNOnzxDV8Xj0+GqgzEIqCMhO7mdkVl3raukLjjJ2rMb9SIvdNihDyCK1C0 dspfIUn6z31ERql3mwVKJYeD6c7rKzlhWJFR/vzFdrFUAmA5TN/X4WDepFBuob7mqdpS ljgVb3RBXFk+B8fQp5EgwVfEipYVhItdAEOBOaFmdHtyzqMRmmq0nXDb26Yt3BuCKoyL azvOTF7idtI2pIEvkpj4IjF55MuI+odEjhOAkGUWCxwIsQMqqpa07w+i6uw9Gy47mY8b DzftNuQuDBpHrUoYM0cFTmILejw2GpPk9O39Nt2U3qBZI5S7cxtrxCRnWjWpZ7CwBuiY qU3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z16si29250367pgj.197.2021.10.26.09.13.13; Tue, 26 Oct 2021 09:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235935AbhJZMY4 (ORCPT + 99 others); Tue, 26 Oct 2021 08:24:56 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:26123 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhJZMYn (ORCPT ); Tue, 26 Oct 2021 08:24:43 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4HdrWB1dWvz1DHs2; Tue, 26 Oct 2021 20:20:22 +0800 (CST) Received: from kwepemm600001.china.huawei.com (7.193.23.3) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 20:22:16 +0800 Received: from huawei.com (10.175.104.82) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 26 Oct 2021 20:22:15 +0800 From: Wang Hai To: , , , CC: , , Subject: [PATCH net v2] usbnet: fix error return code in usbnet_probe() Date: Tue, 26 Oct 2021 20:40:15 +0800 Message-ID: <20211026124015.3025136-1-wanghai38@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600001.china.huawei.com (7.193.23.3) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return error code if usb_maxpacket() returns 0 in usbnet_probe() Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: change '-EINVAL' to '-ENODEV' drivers/net/usb/usbnet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 80432ee0ce69..a33d7fb82a00 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1790,6 +1790,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1); if (dev->maxpacket == 0) { /* that is a broken device */ + status = -ENODEV; goto out4; } -- 2.25.1