Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 09:02:39 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 06/20] trace/osnoise: Allow multiple instances of the
 same tracer
Message-ID: <20211026090239.5ca7d350@gandalf.local.home>
In-Reply-To: <f30262dc-f1cf-4945-5a7d-5ecf5a0b5cc2@kernel.org>
References: <cover.1635181938.git.bristot@kernel.org>
        <69cbbd98cce2515c84127c8827d733dc87b04823.1635181938.git.bristot@kernel.org>
        <20211025220856.7fef7581@rorschach.local.home>
        <f30262dc-f1cf-4945-5a7d-5ecf5a0b5cc2@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 26 Oct 2021 10:38:27 +0200
Daniel Bristot de Oliveira <bristot@kernel.org> wrote:


> >>   * osnoise_register_instance - register a new trace instance
> >>   *
> >> @@ -2048,6 +2066,16 @@ static int osnoise_workload_start(void)
> >>  {
> >>  	int retval;
> >>  
> >> +	/*
> >> +	 * Instances need to be registered after calling workload
> >> +	 * start. Hence, if there is already an instance, the
> >> +	 * workload was already registered. Otherwise, this
> >> +	 * code is on the way to register the first instance,
> >> +	 * and the workload will start.
> >> +	 */
> >> +	if (osnoise_has_registered_instances())
> >> +		return 0;  
> > 
> > Looking at how this is checked before being called, it really should
> > return -1, as it is an error if this is called with instances active.  
> 
> Hum.... maybe my explanation is not good enough. It is not a problem if it is
> called with active instances. It would be an error if the same instance was
> already registered at this point, but that was checked before. Here it is
> checking for other instances that should have enabled the workload.
> 
> Does updating the comment with the one below helps?

No need.


> >> @@ -2096,7 +2131,11 @@ static void osnoise_tracer_start(struct trace_array *tr)
> >>  {
> >>  	int retval;
> >>  
> >> -	if (osnoise_has_registered_instances())
> >> +	/*
> >> +	 * If the instance is already registered, there is no need to
> >> +	 * register it again.
> >> +	 */
> >> +	if (osnoise_instance_registered(tr))

My eyes missed that you removed the osnoise_has_registered_instances() for
the osnoise_instance_registered(tr), and thought you were doing the same
test twice.

My mistake. I need to not review patches at the end of the day when I'm
ready to go to sleep.

-- Steve