Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1481813pxb; Tue, 26 Oct 2021 09:47:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHUQ0YJ9DjRoaireH64QhrQB27vcVy4sfezZOsyLUyLVAreGdmxy+3jXK5qA2uly560tsw X-Received: by 2002:a17:90a:2a8e:: with SMTP id j14mr27405200pjd.227.1635266823178; Tue, 26 Oct 2021 09:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635266823; cv=none; d=google.com; s=arc-20160816; b=N4eYyi/eiw82U72a2D+T58v2zp2HJMpIlBrvEry8rQ6gCG/Dl4Y3kesyI9n9hvVB2V iFApV1QoW7GpxqaO8v0aHqRXaY8ZzpquBV4hw5LIPaiLaIy0PIUjW+JVLWGhjDC8K8Ik xvDYL4urFx3MPKuL9ABOr0d6SlLJIkRqiAs2iKFf1WHwFNNFUapq60fHeQlHXf63TYKP sfIOncvSRgQOXF3yqOFm4y+rpV7xop47dpUVkPgO9Bijqnu/U68SPcZOBjs9M4PTvEwV ZLMDF6cxr6CgzuEZyTb+RJdT4lCq6KW+SyF5I8yZFrXD5FXIKQDDdfIk0k3XjpasotGM hXNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=9wvPWpZ8XXrPZ1OWnyxNz86tqEZ9xVuNUm3UbepsM1s=; b=InDrVxKWNha4oy1E7xVkNewcyrRe9U+OS0dtGpGoJwImlmVICHbwaT9DaVrtiSmlcs fIY3kNT7NnPFJvKROYVozLQReagjAyTnkZMJEdArxd88DTrGtctTRuOf/vQUso6pIO4k rMjkfntI+S3f4tESlT5bIkvwPxYKdDkoccb4ctZTsabGDlKvvy8g62W2dDLD1KoA3vzh MRvGb8C5JR+QiUDmi2Z2EiQY2evTCkzpgG02NlA8dVhTZpXE21muAyBHcMujb+zq9/Zm R1TQ0kYLIOtAfuohiKK8cJ0wsRUde9JH8MSmUoA6h8Jx1ZMjHNB9CHFbdsPLaGi1nsQ+ XyTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si12286302plg.48.2021.10.26.09.46.50; Tue, 26 Oct 2021 09:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236126AbhJZNSB (ORCPT + 99 others); Tue, 26 Oct 2021 09:18:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:58590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235298AbhJZNSA (ORCPT ); Tue, 26 Oct 2021 09:18:00 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43F1460E96; Tue, 26 Oct 2021 13:15:36 +0000 (UTC) Date: Tue, 26 Oct 2021 09:15:34 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Li Zhijian , , , , , Philip Li , kernel test robot Subject: Re: [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace Message-ID: <20211026091534.4ef376e0@gandalf.local.home> In-Reply-To: <20211026211331.8496340b0011127e6505b5ff@kernel.org> References: <20211018132616.2234853-1-lizhijian@cn.fujitsu.com> <20211018221636.47157e52@gandalf.local.home> <20211020112027.b01762f2adcfac99e71dcf99@kernel.org> <20211019223454.5da09d74@gandalf.local.home> <20211020115522.75f3e25247c1d30726e9b130@kernel.org> <20211020101659.42360147@gandalf.local.home> <20211021093131.affc348280aba040f76f769e@kernel.org> <20211025221717.56daf4e8@rorschach.local.home> <20211026211331.8496340b0011127e6505b5ff@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Oct 2021 21:13:31 +0900 Masami Hiramatsu wrote: > > > No, since each testcase must be run under the clean state. Would we need to > > > recover the settings? > > > > I would at least put it back to the default. If someone runs the tests, > > it should at least put it back to what it was at boot. Otherwise, > > someone might run the tests, and then wonder why events are being > > dropped when they are reading the trace. > > Umm, we may need to have a knob to reset the ftrace options... > Can we warn such user that if the ftracetest finds that the current > value is not the same what it sets? You mean before we set pause-on-trace, make sure that it was cleared? That could work too, and then just set everything back to what we expected it to be at the start. -- Steve