Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
To:     Janusz Dziedzic <janusz.dziedzic@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     linux-soc@vger.kernel.org
References: <20211025163121.2189630-1-janusz.dziedzic@gmail.com>
From:   Alex Elder <elder@linaro.org>
Message-ID: <39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org>
Date:   Tue, 26 Oct 2021 08:42:58 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20211025163121.2189630-1-janusz.dziedzic@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> From: Alex Elder <elder@linaro.org>
> 
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.

This was a *long* time ago!
   https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/

The discussion that followed indicated that the thing that needs
QCOM_QMI_HELPERS should *select* it rather than *depend on it.

Will this not work for you?

					-Alex

> We need it in OpenWRT project, when using WiFi backports
> and build ath11k driver. While ath11k driver depends on
> QCOM_QMI_HELPERS we need way to enable this option in
> our kernel.
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
> ---
>   drivers/soc/qcom/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index fe3c486ae32d..16fb8e286015 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
>   	select QCOM_QMI_HELPERS
>   
>   config QCOM_QMI_HELPERS
> -	tristate
> +	tristate "Qualcomm QMI Helpers"
>   	depends on NET
>   
>   config QCOM_RMTFS_MEM
>