Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 07:06:32 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>
Cc:     "dave@stgolabs.net" <dave@stgolabs.net>,
        "josh@joshtriplett.org" <josh@joshtriplett.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
        "jiangshanlai@gmail.com" <jiangshanlai@gmail.com>,
        "joel@joelfernandes.org" <joel@joelfernandes.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] refscale: always log the error message
Message-ID: <20211026140632.GV880162@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20211025032658.22889-1-lizhijian@cn.fujitsu.com>
 <20211025032658.22889-3-lizhijian@cn.fujitsu.com>
 <5f4c53e4-34aa-98f6-343f-0de18df830f2@fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5f4c53e4-34aa-98f6-343f-0de18df830f2@fujitsu.com>
Precedence: bulk

On Mon, Oct 25, 2021 at 06:12:40AM +0000, lizhijian@fujitsu.com wrote:
> 
> 
> On 25/10/2021 11:26, Li Zhijian wrote:
> > Generally, error message should be logged anyhow.
> >
> > Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> > ---
> >   kernel/rcu/refscale.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
> > index a4479f00dcdc..f055d168365a 100644
> > --- a/kernel/rcu/refscale.c
> > +++ b/kernel/rcu/refscale.c
> > @@ -58,8 +58,8 @@ do {											\
> >   	}										\
> >   } while (0)
> >   
> > -#define VERBOSE_SCALEOUT_ERRSTRING(s, x...) \
> > -	do { if (verbose) pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
> > +#define SCALEOUT_ERRSTRING(s, x...) \
> > +	do { pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
> >   
> >   MODULE_LICENSE("GPL");
> >   MODULE_AUTHOR("Joel Fernandes (Google) <joel@joelfernandes.org>");
> > @@ -651,7 +651,7 @@ static int main_func(void *arg)
> >   	result_avg = kzalloc(nruns * sizeof(*result_avg), GFP_KERNEL);
> >   	buf = kzalloc(800 + 64, GFP_KERNEL);
> >   	if (!result_avg || !buf) {
> > -		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> > +		SCALEOUT_ERRSTRING("out of memory");
> 
> '\n' should be added to the last to flush it.

And there might well be other missing "\n" instances in similar messages
in rcuscale.c, rcutorture.c, scftorture.c, locktorture.c, and torture.c.
Please feel free to send a patch for each file needing this help.

I queued your other three patches for v5.17 (not this coming merge window,
but the one after that), thank you!  I did wordsmith the commit logs,
so please check to see if I messed anything up.

							Thanx, Paul

> >   		goto oom_exit;
> >   	}
> >   	if (holdoff)
> > @@ -837,7 +837,7 @@ ref_scale_init(void)
> >   	reader_tasks = kcalloc(nreaders, sizeof(reader_tasks[0]),
> >   			       GFP_KERNEL);
> >   	if (!reader_tasks) {
> > -		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> > +		SCALEOUT_ERRSTRING("out of memory");
> ditto
> 
> Thanks
> Zhijian
> >   		firsterr = -ENOMEM;
> >   		goto unwind;
> >   	}