Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 17:40:09 +0200
From:   Wim Van Sebroeck <wim@iguana.be>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Mantas =?utf-8?Q?Mikul=C4=97nas?= <grawity@gmail.com>,
        "Javier S . Pedro" <debbugs@javispedro.com>
Subject: Re: [PATCH] Revert "watchdog: iTCO_wdt: Account for rebooting on
 second timeout"
Message-ID: <20211026154009.GA22910@infomag.iguana.be>
References: <20211008003302.1461733-1-linux@roeck-us.net>
 <20211020194408.GA2882870@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20211020194408.GA2882870@roeck-us.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

Hi Guenter,

> On Thu, Oct 07, 2021 at 05:33:02PM -0700, Guenter Roeck wrote:
> > This reverts commit cb011044e34c ("watchdog: iTCO_wdt: Account for
> > rebooting on second timeout") and commit aec42642d91f ("watchdog: iTCO_wdt:
> > Fix detection of SMI-off case") since those patches cause a regression
> > on certain boards (https://bugzilla.kernel.org/show_bug.cgi?id=213809).
> > 
> > While this revert may result in some boards to only reset after twice
> > the configured timeout value, that is still better than a watchdog reset
> > after half the configured value.
> > 
> > Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
> > Fixes: aec42642d91f ("watchdog: iTCO_wdt: Fix detection of SMI-off case")
> > Cc: Jan Kiszka <jan.kiszka@siemens.com>
> > Cc: Mantas Mikulėnas <grawity@gmail.com>
> > Reported-by: Javier S. Pedro <debbugs@javispedro.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Any chance you can send a pull request with this patch prior to the v5.15
> release ?

Will do it this evening.

Kind regards,
Wim.