Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211021185335.380810-1-xiehuan09@gmail.com> <20211022180752.0ed07b35@gandalf.local.home>
 <CAEr6+EBq_v+DGSDeiX5Dqc0RgD0sPpbhzpi=T2=r7M2oh90Fpg@mail.gmail.com>
 <20211026104720.03ad26c2@gandalf.local.home> <CAEr6+EDn=g+Q4FfxKn96K5CPcVT9B3FqJA0w4MMfo45DH8oShw@mail.gmail.com>
 <20211026114435.682fe060@gandalf.local.home>
In-Reply-To: <20211026114435.682fe060@gandalf.local.home>
From:   Huan Xie <xiehuan09@gmail.com>
Date:   Wed, 27 Oct 2021 00:11:00 +0800
Message-ID: <CAEr6+ECnV_a+pTxf857Q3=gA5-bi+awtw-w=tzhBJdgXUq4PMQ@mail.gmail.com>
Subject: Re: [RFC PATCH v2] trace: Add trace any kernel object
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>, mingo@redhat.com,
        chenhuacai@kernel.org, linux-kernel@vger.kernel.org,
        Tom Zanussi <zanussi@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Oct 26, 2021 at 11:44 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 26 Oct 2021 23:40:03 +0800
> Huan Xie <xiehuan09@gmail.com> wrote:
>
> > > > static void trace_object_trigger(struct event_trigger_data *data,
> > > > struct trace_buffer *buffer,  void *rec,
> > > >                    struct ring_buffer_event *event)
> > >
> > >
> > > OK, so let me ask this question. What is it that you want to see?
> >
> > Thanks, I got your point now,  my original idea was to just track the
> > flow of objects.
>
> Well, the current patch set doesn't really show any flow of objects, as it
> only records a value that never changes until the next kprobe is hit, and
> we get that from the kprobe itself.

My original purpose was to track which functions the (struct bio)
passed through for the linux block subsystem.
and which functions the (struct page) passed through for the linux
memory subsystem.  ;-)
and I feel this help will be great for learning and developing the linux kernel.

>
> > >
> > > And let's say I want to monitor that __bi_cnt while functions are being
> > > traced. What would be *really cool*, is to mark that value!
> >
> > This is really cool to  get the change of the value. And is a good
> > feature enhancement.
> >
>
> Right, and this is what I thought the purpose of your patch was! :-)
>
> And why I got really excited about it. So I don't see this as a feature
> enhancement to your patch, but the feature enhancement that your patch can
> give us.
>
> -- Steve

--
JeffXie