Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 12:26:14 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     Daniel Bristot de Oliveira <bristot@kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 08/20] rtla: Helper functions for rtla
Message-ID: <20211026122614.017844da@gandalf.local.home>
In-Reply-To: <YXgrLIiK8pwOVsBe@geo.homenetwork>
References: <cover.1635181938.git.bristot@kernel.org>
        <bc01018cef80ddb95fd0ccf1ec72963be7e4fc19.1635181938.git.bristot@kernel.org>
        <YXgrLIiK8pwOVsBe@geo.homenetwork>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 27 Oct 2021 00:22:04 +0800
Tao Zhou <tao.zhou@linux.dev> wrote:

> > +	do {
> > +		retval = read(in_fd, buffer, sizeof(buffer));
> > +		if (read <= 0)  
> 
> check "retval" not read. Like:
> 
>   if (retval <= 0)

OUCH! Good check.

Daniel, did that not produce any warnings??

-- Steve


> 
> > +			goto out_close;
> > +
> > +		retval = write(out_fd, buffer, retval);
> > +		if (retval < 0)
> > +			goto out_close;
> > +	} while (retval > 0);