Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 18:46:38 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH v2] staging: r8188eu: avoid use of goto statement
Message-ID: <YXgw7tOmgO3almYe@kroah.com>
References: <YXbA0BgvKZKXApaW@Sauravs-MacBook-Air.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YXbA0BgvKZKXApaW@Sauravs-MacBook-Air.local>
Precedence: bulk

On Mon, Oct 25, 2021 at 08:06:00PM +0530, Saurav Girepunje wrote:
> Remove the goto statement from _rtw_init_cmd_priv(). In this function
> goto statement can be replace by return statement. By replacing the
> goto statement with return statement local variable "res" is also not
> required. As on goto label exit, function only return it is not
> performing any cleanup. Avoiding goto statement will simplify the function.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> 
> ChangeLog V2:
> 
> 	-Add space after line end on changelog.
> 	-Remove addition blank link after the local variable res
> 	 as per the coding guidelines for linux kernel.
> 

This does not apply to my tree, please rebase and resubmit.

thanks,

greg k-h